Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream HTTP Filter Support for Dynamic Forward Proxy #38452

Open
arkodg opened this issue Feb 13, 2025 · 4 comments
Open

Upstream HTTP Filter Support for Dynamic Forward Proxy #38452

arkodg opened this issue Feb 13, 2025 · 4 comments
Labels
question Questions that are neither investigations, bugs, nor enhancements

Comments

@arkodg
Copy link
Contributor

arkodg commented Feb 13, 2025

Description:

HTTP Filters can be applied to a specific xDS Cluster using the http_filters field .
Can the Dynamic Forward Proxy HTTP Filter be supported as an upstream filter ?

[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg arkodg added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 13, 2025
@mattklein123 mattklein123 added question Questions that are neither investigations, bugs, nor enhancements and removed enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 14, 2025
@mattklein123
Copy link
Member

What is the goal of this exactly? I don't understand what this would do as an upstream filter.

@arkodg
Copy link
Contributor Author

arkodg commented Feb 14, 2025

I would ideally like to model the Dynamic Forward Proxy feature as an input Backend resource in Envoy Gateway. This Backend resource has a 1:1 mapping with an xDS Cluster. So by representing Dynamic Forward Proxy as a Backend Resource (for the end user, its a Backend of type ForwardProxy that discovers endpoints based off DNS of the Host header), I can scope all the xDS configuration (dynamic forward proxy http_filter + special cluster type ) to the xDS Cluster, so only requests meant for this backend executes this filter + cluster, instead of all requests hitting the listener (above example in envoy docs has the filter defined in the hcm)

@wbpcode
Copy link
Member

wbpcode commented Feb 19, 2025

@arkodg could this address your problem because now we can bypass the filter now ?#38237

@arkodg
Copy link
Contributor Author

arkodg commented Feb 19, 2025

thanks @wbpcode, will try it out and share an update here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Questions that are neither investigations, bugs, nor enhancements
Projects
None yet
Development

No branches or pull requests

3 participants