Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why overload manager can't work if envoy build with out Tcmalloc and using jemalloc #38468

Open
wufanqqfsc opened this issue Feb 16, 2025 · 2 comments
Labels
area/overload_manager enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@wufanqqfsc
Copy link

Description:

If config overload manager with envoy.resource_monitors.fixed_heap as resource monitor and with tcmalloc= disable
This overload manager seems not work. So if we are using jemalloc , this Envoy overload manager seems not work ?
So why ? and how to fix this problem if we still need use jemalloc and we also want the overload manager work.

resource_monitors:

  • name: "envoy.resource_monitors.fixed_heap"
@wufanqqfsc wufanqqfsc added the triage Issue requires triage label Feb 16, 2025
@KBaichoo KBaichoo added enhancement Feature requests. Not bugs or questions. help wanted Needs help! area/overload_manager and removed triage Issue requires triage labels Feb 17, 2025
@KBaichoo
Copy link
Contributor

hey @wufanqqfsc

Are you building envoy with jemalloc? This would be very neat to have available upstream.

Regarding why the heap resource monitor does work, you'll need to implement the functions here:
https://github.com/envoyproxy/envoy/blob/main/source/common/memory/stats.cc

As it uses these to calculate the memory used.

@wufanqqfsc
Copy link
Author

yes , @KBaichoo thanks for your comments here.
At least in our case we need it since we were using bytehound (just support jemalloc) for memory profiling debug.
Let's keep in track, we can trying to fix it, but may be also need some support from community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/overload_manager enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

2 participants