Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic modules: allow providing config as bytes instead of string #38469

Open
wtzhang23 opened this issue Feb 17, 2025 · 1 comment · May be fixed by #38470
Open

dynamic modules: allow providing config as bytes instead of string #38469

wtzhang23 opened this issue Feb 17, 2025 · 1 comment · May be fixed by #38470
Labels
area/dynamic_modules enhancement Feature requests. Not bugs or questions.

Comments

@wtzhang23
Copy link
Contributor

wtzhang23 commented Feb 17, 2025 •
edited
Loading

Title: Allow providing config to dynamic modules as bytes instead of just a string

Description:
Add a field raw_filter_config to the DynamicModuleFilter.
Use cases include passing in protos instead of string (json) configs to take advantage of proto-compression and to allow for easier migration of existing filters/xDS control planes.

I'm happy to work on this as I'm very interested in this feature :)
@wtzhang23 wtzhang23 added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Feb 17, 2025
@wtzhang23 wtzhang23 linked a pull request Feb 17, 2025 that will close this issue
Open
@KBaichoo KBaichoo added area/dynamic_modules and removed triage Issue requires triage labels Feb 17, 2025
@KBaichoo
Copy link
Contributor

cc @mathetake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dynamic_modules enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dynamic_modules: support passing in bytes to dynamic modules wtzhang23/envoy
2 participants
@KBaichoo @wtzhang23