Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade P2P protobuf messages #2548

Open
vbar opened this issue Jan 30, 2025 · 2 comments
Open

Upgrade P2P protobuf messages #2548

vbar opened this issue Jan 30, 2025 · 2 comments

Comments

@vbar
Copy link
Contributor

vbar commented Jan 30, 2025

Starknet specifies message formats for Tendermint consensus in https://github.com/starknet-io/starknet-p2p-specs/blob/main/p2p/proto/consensus/consensus.proto , which doesn't exist yet in pathfinder. We should replace https://github.com/eqlabs/pathfinder/tree/main/crates/p2p_proto/proto with https://github.com/starknet-io/starknet-p2p-specs/tree/main/p2p/proto and use the new structure.

@kkovaacs
Copy link
Contributor

A slight update to this: currently, the actual protobuf definitions used by Starkware's implementation are not quite the same as what we have in the p2p-specs repo.

We have a promise that Starkware will publish the "final" protobufs in February in the specs repo -- we could maybe use their protobuf instead?

@vbar
Copy link
Contributor Author

vbar commented Jan 30, 2025

Yes - certainly the upgrade can wait until the spec stabilizes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants