Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inspection findings functionality #2025

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Remove inspection findings functionality #2025

merged 3 commits into from
Feb 17, 2025

Conversation

mrica-equinor
Copy link
Contributor

@mrica-equinor mrica-equinor commented Feb 13, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

andchiind
andchiind reviewed Feb 13, 2025
View reviewed changes
backend/api/EventHandlers/TeamsMessageEventHandler.cs Outdated
Comment on lines 7 to 8
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace these with default JSON handlers while we're at it? Shouldn't be a big change :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but then i have to rewrite the current notification system on teams when there are issues with the robot telemetery

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is a bit of scope creep but makes sense to sdress it now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nw, we can do it in another PR if we make an issue on it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adressed

@andchiind
Copy link
Contributor

Could we add the csharpier commit to the previous commit?

@mrica-equinor mrica-equinor force-pushed the remove-inspection-findings branch from 2230104 to 81ee9e7 Compare February 13, 2025 14:55
andchiind
andchiind reviewed Feb 13, 2025
View reviewed changes
backend/api/Database/Models/Inspection.cs
@@ -117,8 +117,6 @@ or InspectionStatus.Successful

public DateTime? EndTime { get; private set; }

public List<InspectionFinding> InspectionFindings { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add a migration as well before merging

@mrica-equinor mrica-equinor force-pushed the remove-inspection-findings branch 2 times, most recently from c6a1ea1 to 59ffc28 Compare February 14, 2025 12:03
@mrica-equinor
Copy link
Contributor Author

Closes #1543

@mrica-equinor mrica-equinor force-pushed the remove-inspection-findings branch from 59ffc28 to 51a2b79 Compare February 17, 2025 13:15
@github-actions GitHub Actions
Copy link

🔔 Migrations changes detected 🔔
📣 Remember to comment "/UpdateDatabase" after review approval for migrations to take effect!

@github-actions github-actions bot added the database-change Will require migration label Feb 17, 2025
@mrica-equinor
Copy link
Contributor Author

/UpdateDatabase

@github-actions GitHub Actions
Copy link

👀 Running migration command... 👀

@github-actions GitHub Actions
Copy link

❌ Migration failed, please see action log below for details ❌
https://github.com/equinor/flotilla/actions/runs/13371247471

@github-actions GitHub Actions
Copy link

✨ Successfully ran migration command! ✨

@mrica-equinor mrica-equinor merged commit 36aad44 into equinor:main Feb 17, 2025
14 checks passed
@Eddasol Eddasol mentioned this pull request Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
database-change Will require migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrica-equinor @andchiind