Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is pushing release version to dev container registry necessary? #87

Open
olaals opened this issue Dec 23, 2024 · 0 comments
Open

Is pushing release version to dev container registry necessary? #87

olaals opened this issue Dec 23, 2024 · 0 comments

Comments

@olaals
Copy link
Contributor

olaals commented Dec 23, 2024

Describe the improvement you would like to see
Consider removing the push image to dev container registry under .github/workflows/deploy-to-staging.yml. I believe we never pull or use this image.

How will this change existing functionality?
I belive this will not change the existing functionality

How will this improvement affect the current Threat Model?
No change

Consider removing this:

  build-and-push-release-to-dev:
    name: Update containers in dev with version tag
    uses: ./.github/workflows/publish_component.yml
    with:
      Registry: auroradevacr.azurecr.io
      ImageName: robotics/inspection-data-analyzer
      Tag: ${{ github.event.release.tag_name }}
    secrets:
      RegistryUsername: ${{ secrets.ROBOTICS_AURORADEVACR_USERNAME }}
      RegistryPassword: ${{ secrets.ROBOTICS_AURORADEVACR_PASSWORD }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant