Add ERC: Wallet Call Simulation API #892
Draft
+227
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File
|
|
The commit 3ddc7fb (as a parent of 1f189dd) contains errors. |
ajhodges
reviewed
Feb 11, 2025
| ### `traceMalicious` Capability | ||
|
|
||
| Capability to trace malicious calls. Needs discussion. | ||
|
|
There was a problem hiding this comment.
Maybe also a separate detectMaliciousAddresses capability? It seems functionally separate from traceMalicious; it'd be used to flag i.e. token transfers to known scam addresses?
ajhodges
reviewed
Feb 11, 2025
| ### `traceMalicious` Capability | ||
|
|
||
| Capability to trace malicious calls. Needs discussion. | ||
|
|
There was a problem hiding this comment.
I can also see adding a 'stateOverride' capability
ajhodges
reviewed
Feb 11, 2025
| address: `0x${string}`; | ||
| data: `0x${string}`; | ||
| topics: `0x${string}`[]; | ||
| }[]; |
There was a problem hiding this comment.
Call traces are also useful for surfacing internal contract calls and internal eth transfers, if the simulator supports outputting them. We could mark that as an optional field in the response (or make this a capability?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.