Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

EDCI Commons does not compile because of non-existing dependency Gson-extras #2

Open
SeSodesa opened this issue Aug 19, 2021 · 1 comment

Comments

@SeSodesa
Copy link

SeSodesa commented Aug 19, 2021

Like the title implies, Google does not maintain their Gson-extras package on Maven central, but it is still included as a dependency in

edci-commons/pom.xml .

This prevents the compilation edci-commons and therefore the rest of the sub-packages (or whatever the heck these are called in the Java world) in this repository.

Danilo Pianini actively maintains a fork of the Google Gson extras at the address https://github.com/DanySK/gson-extras, and on Maven central at https://search.maven.org/artifact/org.danilopianini/gson-extras. Replacing

<dependency>
    <groupId>com.google.code.gson</groupId>
    <artifactId>gson-extras</artifactId>
    <version>${org.gson.version}</version>
</dependency>

with

<dependency>
    <groupId>org.danilopianini</groupId>
    <artifactId>gson-extras</artifactId>
    <version>0.2.2-dev1n+f8657bfc</version>
</dependency>

in

edci-commons/pom.xml

allows edci-commons to compile again. I would make a pull request, but forking of this repository is disallowed.

@Esayos
Copy link
Contributor

Esayos commented Sep 20, 2021

Hi @SeSodesa, we have found in fact some dependencies that require an update to the repository were they are found.
For next version, we will include a new maven settings file which should include all of the required repositories.

In the meantinme, you can add https://artifactory.cronapp.io/public-release/ repository to your maven settings, which is the one that will be used in future releases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants