-
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Planner: continue in PV mode when planner finishes #6910
Comments
I get the idea, but I think we are introducing a lot of complexity where. We'll have to visualize this extra SoC limit in addition to the existing ones (min soc, target soc, vehicle limit). In addition it's not obvious to the user which soc is the limit. As an example: I use target time before longer trips. In these scenarios I want the vehicle reach a higher soc (100%) than my usual limit (80%). But you could also make the case the other way around where it's more of a minimum value as you described. I'm not sure if it's wise to open this topic right now. I see that we have work to do here especially when we are thinking about departure schedules / recurring targets. see #5492 |
For the visualization you could simply insert 2 bars/slider instead of currently only one bar/slider. The first bar sets the minSOC and the second the target SOC. |
I think the real point here is that we should treat the planner soc as a |
As a naive user who didn't read the doc, the described behavior was actually my expectation for min+PV mode. Eventually this is also my main use case, preserve a minimum SoC for daily trips and in case of PV surplus charge to max. |
It is unlcear what this issue should achieve. Planner uses target soc. Once target is achieved, PV mode would stop charging as well. We might revisit this behaviour once we address #5492. |
From Slack: we should think about splitting the planner target soc from the actual target, i.e. treat planner more as a minimum value.
/cc @naltatis
The text was updated successfully, but these errors were encountered: