Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new widgets designs #268

Merged
merged 4 commits into from
Oct 13, 2021
Merged

feat: new widgets designs #268

merged 4 commits into from
Oct 13, 2021

Conversation

julianpoma
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 12, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/everydotorg/donate-button/Fv43khJ3Xn4pV3mac2WgKGpNNg8g
✅ Preview: https://donate-button-git-widget-design-updates-everydotorg.vercel.app

@julianpoma @markulrich
feat: new widgets designs
d24cc94 
* wip: make a widget open by default

* wip: general layout

* wip: page navbar and crypto

* feat: crypto i18n

* wip:input

* wip: popover styles

* wip: tax country

* wip: mobile styles

* wip: expandable content

wip: expandable content

* wip: close button & pages styles

* feat: increase tap target of currency selector

* feat: remove unused code

* fix: lint

* feat: min donation amount error

* feat: frequency popover & close button styles

* feat: showInputButtons & showTaxResidency config

* feat: widget size improvements

* feat: improvements on widget sizing

* fix: build

* fix: button separation and font sizes not used

* feat: hide crypto and pages

* feat: safari styles improvements

* feat: make expandable tap area bigger

* feat: md styles

* Update income movement defaults

Co-authored-by: Mark Ulrich <[email protected]>

* feat: update defaults

Co-authored-by: Mark Ulrich <[email protected]>

* feat: update minHeight

* feat: showAlternatePayments config

* fix: remove console.log

* feat: description font size variable

* feat (new-widget): country selector (#259)

* feat: country selection styles

* feat: selected country with border

* feat: tax residency color and alignment

* wip: update incomemovement config

* feat: improve divider styles

* fix: center text

* feat: variable font size

Co-authored-by: Mark Ulrich <[email protected]>
@julianpoma julianpoma force-pushed the widget-design-updates branch from 4896d6d to d24cc94 Compare October 12, 2021 12:28
@julianpoma julianpoma force-pushed the widget-design-updates branch from 780311b to 5642337 Compare October 12, 2021 13:03
@micamastro
Copy link

Hey @markulrich ,
With the new layout updates we are releasing a new version of the widget: 0.4
We believe that in general it is better to release a different version and ask non-profits to update the version than to introduce the changes without them knowing about it.
Having said that, we should ask Livebetter to upgrade to the new version once this PR is merged. Do you agree with this approach?

@markulrich
Copy link
Member

markulrich commented Oct 12, 2021 •
edited
Loading

@micamastro for this case I've told them to expect the update and it would be nice for them to get it automatically, so we can stay on 0.3, but no strong opinion we could just ask them to change. Agree we should be more explicit about asking people to be on the "latest" version, created #270

Also, I noticed a file give2asiabg.jpeg was added, but ideally we shouldn't have that

markulrich
markulrich approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@markulrich markulrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julianpoma julianpoma merged commit 0a77c49 into main Oct 13, 2021
@julianpoma julianpoma deleted the widget-design-updates branch October 13, 2021 13:31
@julianpoma julianpoma restored the widget-design-updates branch October 13, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markulrich markulrich markulrich approved these changes

@martinbianchi martinbianchi Awaiting requested review from martinbianchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianpoma @micamastro @markulrich