Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-parsing FCS file (and a fix) #25

Open
matt-faria opened this issue Feb 25, 2021 · 1 comment
Open

non-parsing FCS file (and a fix) #25

matt-faria opened this issue Feb 25, 2021 · 1 comment

Comments

@matt-faria
Copy link

Hi, flow cytometry files from Apogee don't parse with fcs parser.

They (inexplicably) have a bunch of spaces before $P1N in the header, this can be remedied without too much trouble though.

An example of an FCS file with the issue:
https://bitbucket.org/mwfcomp/incubation_experiment/raw/a6ef3685428f6e373442ab0e04b553b36bbcdd48/sample_data/2015-07-08/THP-1%20-%20235%20nm%20Capsule%2016%20hr.fcs

And a (slightly hacky) script to fix this per file:
https://bitbucket.org/mwfcomp/incubation_experiment/raw/a6ef3685428f6e373442ab0e04b553b36bbcdd48/fcs_file_fixer.py

This could be dealt with more elegantly in the parser, I would be happy to put together a solution for it if this is acceptable and this project is still being maintained?

@eyurtsev
Copy link
Owner

PRs will be very welcome. I'm happy to merge as long as you include unit-tests.

For style if possible follow PEP-8 conventions and google style doc-strings (I don't have any linters that check for that, so if that's difficult I can follow up with appropriate linting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants