-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Réécriture du frontend #415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ropdown, and more
… for HTML and CSV outputs
7974881
to
1cc83c9
Compare
3fbaa00
to
605413d
Compare
14eefdc
to
a214404
Compare
6d5f217
to
67d9853
Compare
41123e2
to
be1657c
Compare
3db62b7
to
5431936
Compare
This was referenced Jan 26, 2024
This was referenced Feb 7, 2024
This was referenced May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Que se passe-t-il ici ?
Action
deviennent desController
avec des@Render()
{{ path('name', params) }}
(NestJS ne fournit pas de tel utilitaire, contrairement à Symfony)?next=...
)Autres notes
File/
(plus utilisé depuis le retrait des devis, factures, etc)Taille du build
$ make assets dist/public/faircalendar.js 87.3kb dist/public/main.css 14.1kb dist/public/faircalendar.css 7.0kb dist/public/main.js 3.6kb ⚡ Done in 59ms
Sans le composant EventCalendar, le build JS pèse moins de 5ko (!). J'ai splitté le JS de sorte à ne charger EventCalendar que sur la page FairCalendar. On ne charge alors que 43 ko de données sur la majorité des pages. ❤️ 🍀
TODO
command
, comme en Syfmony à la Fairness, plutôt que passer directement les entités commeCustomer
ouProject
. Ça permettrait de refaire le rendu dans lepost()
avec les données du formulaire qui ont déclenché l'erreur. Actuellement les données sont celles dans la DB, ou elles sont vides si c'est un formulaire de création.