copr-frontend built failed after upgrading python3.11

[pkking]

here's two different build log:
the succeed log

the failed log

after some investigate, seems the py_compile command line change the behavior
in python3.9

$ python3 -V
python 3.9.9
$ python3 -m py_compile
$ echo $?
0

in python3.11

$ python3 -V
python 3.11.6
$ python3 -m py_compile
usage: py_compile.py [-h] [-q] filenames [filenames ...]
py_compile.py: error: the following arguments are required: filenames
$ echo $?
2

[pkking]

a quick fix is comment this line:

%py_byte_compile %{__python3} %{buildroot}%{_datadir}/copr/coprs_frontend/tests

then the build succeed

[FrostyX]

That's strange. We regularly rebuild the packages and didn't notice this. I just submitted
https://copr.fedorainfracloud.org/coprs/g/copr/copr/build/8675417/

I didn't test specifically for Python 3.11 but it worked fine for Python 3.12 (F40) and Python 3.13 (F41)

[pkking]

That's strange. We regularly rebuild the packages and didn't notice this. I just submitted https://copr.fedorainfracloud.org/coprs/g/copr/copr/build/8675417/

I didn't test specifically for Python 3.11 but it worked fine for Python 3.12 (F40) and Python 3.13 (F41)

The root cause:
py_compile.py distributed with python failed when no valid params provides instead of succeed before

the logs below maybe show the magic:

+ [[ /usr/bin/python3 =~  - ]]
+ clamp_source_mtime /usr/bin/python3 /builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests
+ python_binary='env /usr/bin/python3'
+ bytecode_compilation_path=/builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests
+ PYTHONPATH=/usr/lib/rpm/redhat
+ env /usr/bin/python3 -s -B -m clamp_source_mtime /builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests
Listing '/builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests'...
Can't list '/builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests'
++ /usr/bin/python3 -c 'import sys; sys.stdout.write('\''{0.major}{0.minor}'\''.format(sys.version_info))'
+ python_version=313
+ '[' 313 -ge 39 ']'
+ py39_byte_compile /usr/bin/python3 /builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests
+ python_binary='env PYTHONHASHSEED=0 /usr/bin/python3'
+ bytecode_compilation_path=/builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests
+ env PYTHONHASHSEED=0 /usr/bin/python3 -s -B -m compileall -j4 -o 0 -o 1 -s /builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT -p / --hardlink-dupes --invalidation-mode=timestamp /builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests
Listing '/builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests'...
Can't list '/builddir/build/BUILD/copr-frontend-2.1-build/BUILDROOT/usr/share/copr/coprs_frontend/tests'

seems Fedora shipped a py39_byte_compile and it keep the old version of py_compile.py to make the build happy, im not sure this is a fedora specific workaround or a more common solution in the entire RPM-based ecosystem

[nikromen]

interesting. So perhaps we could exclude that line for openeuler distros in the specfile just with if statement? Would that work for you?

[FrostyX]

Looking at the Fedora Python packaging gudielines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Appendix/#manual-bytecompilation

If you have *.py files outside of the /usr/lib(64)?/pythonX.Y/ directories and you require those files to be byte compiled (e.g. it’s an importable Python module) you MUST compile them explicitly using the %py_byte_compile macro.

So we cannot remove those lines from the specfile. And looking at the provided examples, I think we do it correctly. So a condition to not do this on openEuler as @nikromen is suggesting is IMHO the way to go.

[pkking]

Looking at the Fedora Python packaging gudielines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Appendix/#manual-bytecompilation

If you have *.py files outside of the /usr/lib(64)?/pythonX.Y/ directories and you require those files to be byte compiled (e.g. it’s an importable Python module) you MUST compile them explicitly using the %py_byte_compile macro.

So we cannot remove those lines from the specfile. And looking at the provided examples, I think we do it correctly. So a condition to not do this on openEuler as @nikromen is suggesting is IMHO the way to go.

I agree the rule we can't remove any byte comiple code, but think we can safely remove this line because the tests dir is empty at the frontend byte compile stage :)

[pkking]

To be more clear, this error was happend in openEuler only when the py_byte_compile command given an empty dir as argument, so i think the line is redundant

[FrostyX]

That we probably can.

$ rpm -ql copr-frontend |grep test
/etc/copr/copr_unit_test.conf
/usr/share/copr/coprs_frontend/commands/test.py
/usr/share/copr/coprs_frontend/coprs/static/components/c3/extensions/exporter/test.png

(the tests directory isn't there)

Checking the specfile and we explicitly do

copr/frontend/copr-frontend.spec

Line 264 in 4acf287

rm -rf %{buildroot}%{_datadir}/copr/coprs_frontend/tests

Will you send a PR @pkking ?

[pkking]

Sure, im happy to submit a PR later :)