Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items that were previously unscrobbled do not appear in the "Biggest climbers" lists #47

Open
TheOptimisticFactory opened this issue Feb 11, 2024 · 9 comments

Comments

@TheOptimisticFactory
Copy link

TheOptimisticFactory commented Feb 11, 2024

Hi,

After stumbing on this project today, and being amazed by the stats offered, I noticed something rather odd in the biggest climbers part of the tracks.

Current results

  • For my profile, it currently showcases these 3 songs
    image

  • If we take a deeper look at the n°1 result, we can see the following metrics: from unplayed, then 1 scrobble the next month, and then 101 scrobbles the next
    image

  • And even weirder the 10th entry on the biggest climbers is a song having as low as 11 scrobbles in a single month

Expectations

  • I would have expected this song to be in the 1st spot: from unplayed to 326 scrobbles in a single month
    image

Question

  • What dictates that a given track ranks higher than others in the biggest climbers?
@TheOptimisticFactory
Copy link
Author

After digging, I got the answer:

  • to be registered in the biggest climbers/fallers an artists/album/track has to be scrobbled 2 consecutive months, and have the largest rank difference in terms of scrobbles.

Meaning:

  • an unplayed artist/album/track won't be registered on its first month of being scrobbled.

I think having a newly discovered song (scrobbles:0) should be counted in the biggest climbers/fallers

@felhag
Copy link
Owner

felhag commented Feb 13, 2024

Thanks for the clear issue :). You're right, climbers/fallers are only counted from the second month they appear. It doesn't really have a ranking if it's not scrobbled I figured... And (maybe, I'm not sure how it is ordered for artists/albums/tracks with the same amount of scrobbles) the list will be filled with climbers from 0 to 1 scrobbles which would be kinda boring.

I don't think the months have to be consecutively though. If so that is clearly a bug.

@TheOptimisticFactory
Copy link
Author

TheOptimisticFactory commented Feb 15, 2024

the list will be filled with climbers from 0 to 1 scrobbles which would be kinda boring

That is a fair point.

Maybe some middleground could be found, where a threshold of scrobbles has to be reached for a newly discovered to be considered in the climber (ideally based on the average scrobble count of the profile).

This would allow an unplayed song to be registered in the biggest climbers assuming it got played enough on the month of its discovery.

In my case having one song going from unplayed to literal rank n°1 in a single month would certainly be above said threshold. The current implementation occults it entirely, as the rank remains 1 between the discovery month and the following.

@felhag
Copy link
Owner

felhag commented Feb 19, 2024

Yeah, I agree, a threshold would be a nice solution. A similar threshold is used for some other lists (for example golden oldies, average scrobble per track). But it's not dynamically determined, it's 50 for artists, 30 for albums and 10 for tracks.

@felhag felhag closed this as completed in 83f9db5 Apr 5, 2024
@felhag
Copy link
Owner

felhag commented Apr 5, 2024

I added the threshold (50 for artists, 30 for albums and 10 for tracks), but didn't include the unscrobbled month into the biggest climbers/fallers lists (yet?). Do you think this solves your issue? If not you can reopen the issue it if you like.

@TheOptimisticFactory
Copy link
Author

Thanks @felhag, that sounds promising!

I will try this out and report if the results are matching expectations.
Is https://lastfmstats.com up-to-date with these changes?

@felhag
Copy link
Owner

felhag commented Apr 5, 2024

@TheOptimisticFactory, yes, it's up to date!

@TheOptimisticFactory
Copy link
Author

TheOptimisticFactory commented Apr 11, 2024

I added the threshold (50 for artists, 30 for albums and 10 for tracks), but didn't include the unscrobbled month into the biggest climbers/fallers lists (yet?). Do you think this solves your issue? If not you can reopen the issue it if you like.

I imported my profile on https://lastfmstats.com just now, and I must say that I did not notice much differences compared to the previous results.

To clarify:

  • The current algorith is valid, and works as intended: it displays items that indeed climbed the ranking rapidly, UNDER THE ASSUMPTION that item got scrobbled at least once in the past.

  • But I would still expect are unscrobbled items to be showcased in the biggest climbers/fallers assuming the climb is over a given threshold. it could be an even bigger threshold than for already-scobbled items, to make sure they do not pollute the results.

I am re-opening the issue in hope to hopefully see unscrobbled items to get the recognition they deserve :)

EDIT: I do see any button to re-open the issue on my end.


Side-note: @felhag your tool is awesome by the way.

@TheOptimisticFactory TheOptimisticFactory changed the title Biggest climbers yields unexpected results Items that were previously unscrobbled do not appear in the "Biggest climbers" lists Apr 11, 2024
@felhag felhag reopened this Apr 16, 2024
@felhag
Copy link
Owner

felhag commented Apr 16, 2024

I reopened it, I'll have another look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants