Add cmd-q shortcut on macOS #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrled
force-pushed
the
add-macos-cmd-q
branch
from
9a85b72 to
39a0228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire up the Quit action to the File menu on macOS.
This enables the typical Cmd-Q shortcut for quitting the app, which is a standard on macOS. To do this, I created a global menu, which macOS uses automatically. (Actually, there is always a menu bar on macOS no matter what. This change enables the Quit menu item, which exists but is grayed out otherwise.) The menu doesn't appear on other platforms.
If this is a wrongheaded way to do this, I'd be happy to change it, and not offended if you just need to close.