Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the marker schema, add the ability to mark fields as hidden #5299

Open
mstange opened this issue Jan 10, 2025 · 2 comments
Open

In the marker schema, add the ability to mark fields as hidden #5299

mstange opened this issue Jan 10, 2025 · 2 comments
Labels
markers Anything to do with marker data structures, marker chart, or the marker table profile data Issues related to the profile format, data structure, or profile upgraders

Comments

@mstange
Copy link
Contributor

mstange commented Jan 10, 2025

Some markers have fields which shouldn't be displayed in the list of fields in the tooltip and in the sidebar.

We should have a way to mark these fields as hidden.

I know of three reasons for wanting to hide fields:

#798 (comment) discusses a third reason why you might want to hide a field: If we supported tooltip entries of the type usage / capacity (full%), you wouldn't want a separate row for the capacity by itself.

┆Issue is synchronized with this Jira Task

@mstange
Copy link
Contributor Author

mstange commented Jan 10, 2025

Today, the way to use fields only in the tooltip or in graphs is to omit them from the schema. But we'll want to have all fields listed in the schema, to allow for future improvements to the profile storage format.

@mstange
Copy link
Contributor Author

mstange commented Jan 10, 2025

Also, today, if your tooltip label includes a field that's not listed in the schema, the field value must be a string, because you didn't write down the field format anywhere. For example it can't be a value in bytes.

@canova canova added profile data Issues related to the profile format, data structure, or profile upgraders markers Anything to do with marker data structures, marker chart, or the marker table labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers Anything to do with marker data structures, marker chart, or the marker table profile data Issues related to the profile format, data structure, or profile upgraders
Projects
None yet
Development

No branches or pull requests

2 participants