Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ens_name not correctly set in sfcf module #252

Closed
fjosw opened this issue Jan 3, 2025 · 1 comment · Fixed by #253
Closed

ens_name not correctly set in sfcf module #252

fjosw opened this issue Jan 3, 2025 · 1 comment · Fixed by #253
Assignees
@jkuhl-uni
Labels
bug Something isn't working

Comments

@fjosw
Copy link
Owner

fjosw commented Jan 3, 2025

While going over the type hints in #251 I noticed that ens_name does not seem to get properly propagated in _get_rep_names and _get_appended_rep_names.

https://github.com/fjosw/pyerrors/blame/997d360db37133b7dcbef8b9dbf1e3aff4d7c4bf/pyerrors/input/sfcf.py#L657-L660

Can you have a look @jkuhl-uni ?
@fjosw fjosw added the bug Something isn't working label Jan 3, 2025
@jkuhl-uni
Copy link
Collaborator

Oh, you're right, there are a few 's too much. Thanks for noticing, I'll take care of it, this is a quick fix, I guess :)

@jkuhl-uni jkuhl-uni mentioned this issue Jan 6, 2025
Merged
@fjosw fjosw closed this as completed in #253 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkuhl-uni jkuhl-uni

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/sfcf ensname jkuhl-uni/pyerrors
2 participants
@fjosw @jkuhl-uni