Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force flush changes to filesystem #5

Open
felipesere opened this issue Feb 19, 2020 · 3 comments
Open

Force flush changes to filesystem #5

felipesere opened this issue Feb 19, 2020 · 3 comments
Labels

Comments

@felipesere
Copy link

👋 Thank you for writing JFS!
I am using it as an alternative store for a side project.
While running my tests, I noticed that my delete case would sporadically fail.
It does a bunch of inserts, then a bunch of deletes and then reads to see if they still there.

I think adding a f.sync_all()? at the end of save_object_to_file should at least alleviate the case.

I can open a PR if you want.

@flosse
Copy link
Owner

flosse commented Feb 19, 2020

Thanks for reporting!

I can open a PR if you want.

That would be awesome! 👍

@flosse flosse added the bug label Feb 19, 2020
@felipesere
Copy link
Author

felipesere commented Feb 19, 2020

I added the alleged f.async_all() and it didn't really help. :(

My tests pass if I have a different file per running test. I am not 100% if Rust runs the tests concurrently?

@flosse
Copy link
Owner

flosse commented Feb 22, 2020

@felipesere Could you add a testcase to reproduce the behavior?
I can't find a way to provoke this bug :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants