Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A call to val-pprint timed out #101

Open
agzam opened this issue Oct 23, 2023 · 7 comments
Open

A call to val-pprint timed out #101

agzam opened this issue Oct 23, 2023 · 7 comments

Comments

@agzam
Copy link

agzam commented Oct 23, 2023

Sometimes a window such like this pops up. Not sure what would cause that.

image

@jpmonettas
Copy link
Member

I should improve that message, but this could happen when you try to step into the result of a (future ...) or a (promise) that still doesn't contain a value, so it will block. In order to not block the debugger indefinitely it will timeout after some seconds.
Makes sense?

@agzam
Copy link
Author

agzam commented Oct 23, 2023

The issue for me that the dialog is obtruding. I don't mind seeing it, but the fact that it's a modal, is a bit annoying. If you get a lot of these (and apparently you can), you end up having to move the cursor and click the button, a lot. Perhaps it can appear somewhere in the UI in a non-blocking way, maybe briefly in the status bar, I'm not sure. Just to be clear: this isn't critical, yet something to think about. You probably will have to think how to display similar messages in a non-obtrusive way at some point anyway.

@jpmonettas
Copy link
Member

Interesting, I guess we would need to do something about it then.
Out of curiosity, what kind of code generates all those unfulfilled promises after execution?

@velios
Copy link
Contributor

velios commented Dec 18, 2023

@jpmonettas I can confirm that this problem often occurs when I inspect large work projects. I can't provide a report on what's causing it, but it's really annoying when you have to make multiple clicks to move each step forward or backward. It would be great to have an option as suggested above so that this is not blocked by the modal window.

@jpmonettas
Copy link
Member

I would really like to understand the cause of this, what scenarios lead to this experience, since I haven't encountered it on my projects, so maybe we can improve the UX in this situations much better than just hack around it. Can anybody report what values it is trying to access? (promises, futures, etc) or what kind of code leads to this behavior? In the meantime, when dealing with unrealized values, I guess you can click the expressions you are interested in, instead of hitting next/prev, and avoid clicking the ones you know are unrealized ones.

@jpmonettas
Copy link
Member

I'm also not sure that getting rid of the modal will make it less annoying. Since value pprinting is timing out, it means that even without a modal, on each step you will have to wait for the timeout (4 secs) before going to the next step, which is also annoying.

@velios
Copy link
Contributor

velios commented Dec 18, 2023

It happens pretty often in my work project. With pure data all fine.
But often i use storm to inspect code inside deftest and in project we use
(def ^:dynamic *system* nil) which store our integrant or component components.
I check and modal appears mostly in this cases. And what annoying it appear without focus, so you can't just hit enter. And if you use multi-monitor alert appears on primary monitor and flowstorm mostly open in my case on secondary monitor. Also often i have more than one alert from one step =( Walk through prev/next or just click doesn't matter alert can appear in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants