Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave without changes floods Nextcloud file versions #1025

Closed
EverardNisse opened this issue Feb 21, 2024 · 1 comment · Fixed by #1026
Closed

Autosave without changes floods Nextcloud file versions #1025

EverardNisse opened this issue Feb 21, 2024 · 1 comment · Fixed by #1026

Comments

@EverardNisse
Copy link

Describe the bug
Rnote autosave without changes to file triggers a sync and floods the logs and file versions of the Nextcloud client / server.
Notably autosave is done even when the file has not been changed and Rnote is out of focus (meaning no view movement either)

To Reproduce
Steps to reproduce the behavior:

  1. Use Nextcloud client to sync a folder
  2. Open a new rnote document
  3. Enable Autosave
  4. Open Nextcloud client notifications from the taskbar (pictured below)

Expected behavior
Autosave detects that no changes have been made so it doesn't trigger the save which then triggers Nextcloud.

Console Output
N/A Cannot run Flatpak on machine in question

Screenshots
rnote-nextcloud-sync

Desktop (please complete the following information):

  • OS: Arch
  • App Version: Rnote v0.9.4
  • Installation Source: Archlinux Community Repo
  • Desktop Environment: KDE 5.27
  • Display Server: Wayland
  • Input Source: Touch laptop

Additional context
N/A

@Doublonmousse
Copy link
Collaborator

Right.
For now the autosave also only applies to the opened tab of each window, I think it makes sense to autosave all unsaved changes from all tabs (and don't save anything that doesn't have any unsaved things).

It does not save anything if the file was not first saved to disk (relating this to #945).

I think I have a first working implementation for the first point, although there's still some more work (on catching unwraps and the like)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants