Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small dots that appear on the screen and cannot be erased #1108

Closed
jfab20 opened this issue May 30, 2024 · 11 comments
Closed

Small dots that appear on the screen and cannot be erased #1108

jfab20 opened this issue May 30, 2024 · 11 comments
Labels
bug Something isn't working

Comments

@jfab20
Copy link

jfab20 commented May 30, 2024

While drawing/writing, some dots randomly appear on the screen and cannot be erased

image

I can select the dots and when I enlarge them I get this:

image

The only way to delete them is to select them and press the delete button on my computer (even when they are large). I cannot reliably reproduce how to create this dots but they appear randomly while I'm writing and it gets annoying.

Expected behavior
Write normally without random dots appearing on the screen.

I find this hard to reproduce on command but this bug is extremely common, I don't know what triggers it
image

Desktop (please complete the following information):

  • OS: arch 6.9.2-1
  • App Version: Rnote v0.10.2-1
  • Installation Source: Arch linux community repo
  • Desktop Environment: Hyprland
  • Display Server: Wayland
  • Input Source: External graphics tablet
@Doublonmousse
Copy link
Collaborator

Maybe it's related to #414 or #889 ?

@jfab20
Copy link
Author

jfab20 commented May 30, 2024

Maybe it's related to #414 or #889 ?

I don't think the selection tool has anything to do with this because this happens while writing and I don't use the selection tool often.

Maybe first I would like to know what are these points, are they produced by the pen tool? Why can't I erase them? Here is a video

recording.mov

@flxzt flxzt added the bug Something isn't working label Jun 7, 2024
@flxzt
Copy link
Owner

flxzt commented Jun 7, 2024

Can you share the rnote file that contains these non-erasable dots? You can remove all other data on it if it is sensitive to you.

@jfab20
Copy link
Author

jfab20 commented Jun 7, 2024

Sure.
test.zip

@flxzt
Copy link
Owner

flxzt commented Jun 9, 2024

Thanks, that helped.

Looks like single element strokes were not generating hitboxes that are queried by the eraser. They do have bounds, that's why they can be selected.

The remaining issue is: why are there random single element strokes appearing for you? It doesn't read like that was done intentionally by you

flxzt added a commit that referenced this issue Jun 9, 2024
@RayJW
Copy link
Contributor

RayJW commented Jun 9, 2024

The remaining issue is: why are there random single element strokes appearing for you? It doesn't read like that was done intentionally by you

Not OP, but I can say that definitely happens to me as well occasionally. I'm not sure, but my gut feeling says it usually happens when just tapping the screen with the pen, on accident most of the time. Say I was selecting something and then either the selection goes away before I tap the screen or there's immediately a second tap for some reason. And no, so far I never intended to create these single element strokes.

@flxzt
Copy link
Owner

flxzt commented Jun 9, 2024

Probably happening because of the immediate return of the selector/eraser tools instead of needing another up->down cycle. I think #414 is related

@jfab20
Copy link
Author

jfab20 commented Jun 9, 2024

Probably happening because of the immediate return of the selector/eraser tools instead of needing another up->down cycle. I think #414 is related

In my case I do think it is caused by the immediate return of the eraser tool because I don't use the selector tool, and I remember that while I was trying to recreate this in the file I sent you, I had to draw and change quickly to the eraser, that is how I consistently reproduced the issue.

Maybe it has to do with my tablet? Just in case I use the tablet "One by Wacom".

@flxzt
Copy link
Owner

flxzt commented Jun 16, 2024

The event stream log when this occurs would be very helpful. You can capture it through RUST_LOG=rnote=trace (but be warned, it's very verbose)

@jfab20
Copy link
Author

jfab20 commented Jun 19, 2024

The event stream log when this occurs would be very helpful. You can capture it through RUST_LOG=rnote=trace (but be warned, it's very verbose)

Sure. Is this enough?

log.txt

@jfab20
Copy link
Author

jfab20 commented Aug 3, 2024

@flxzt Hey, was this fixed by some update? I have rnote 0.11.0-1 and I cannot longer reproduce the bug. I think I will close the issue now. Thank you very much!

@jfab20 jfab20 closed this as completed Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants