improv : autosave all tabs, but only for files that have unsaved changes #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxzt
reviewed
Feb 22, 2024
flxzt
reviewed
Feb 22, 2024
flxzt
reviewed
Feb 22, 2024
flxzt
reviewed
Feb 22, 2024
flxzt
reviewed
Feb 22, 2024
|
thanks a lot! I added some comments. |
flxzt
changed the title
|
Fix the clippy warning (see here), otherwise it looks good to me. |
|
The clippy warning should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working implementation to test, although there is quite a few things that should be changed for robustness (catching unwrap errors and reformatting code).
Fixes #1025