Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AvnuProvider failing test #474

Open
ptisserand opened this issue Feb 25, 2025 · 1 comment
Open

fix AvnuProvider failing test #474

ptisserand opened this issue Feb 25, 2025 · 1 comment
Labels
integration package:avnu_provider

Comments

@ptisserand
Copy link
Collaborator

There is a failing test for avnu_provider in CI (see https://github.com/focustree/starknet.dart/actions/runs/13471925415/job/37773272836?pr=436)

After investigation it appears that maxGasTokenAmount could be underestimated.

I think there is 2 alternatives to solve it:
A- Ensure maxGasTokenAmount is computed with current gas price
B- (the hacky one): increase the hardcoded value
@rukafe0x
Copy link
Contributor

Hi @ptisserand , may i take this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
integration package:avnu_provider
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptisserand @rukafe0x