This repository has been archived by the owner on Jan 31, 2025. It is now read-only.
[ISSUE-460] - Font Size Audit #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.3.0 release PR
… ranging from xx small - xx large, consisting of 7 fontSize delcarations total
tropicandid
changed the title
tropicandid
suggested changes
Jul 31, 2024
There was a problem hiding this comment.
@christopherhodges There are two small slug changes, but One thing that is a late breaking request from FEDs. The request was to start with 9 fonts (6 header and 3 body) would you mind adding two additional font sizes and adjusting the slugs and sizes accordingly? I updated the associated issue for this. Other than those two things this is looking good! Sorry for the last minute change to AC
|
@tropicandid this should be good to go! I set the largest font-size to 44px. I tried to mimic what twentytwentyfour uses but in pixel units instead of rems. |
tropicandid
approved these changes
Jul 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #460