Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfinterface and messaging #30

Open
bdw429s opened this issue May 5, 2017 · 2 comments
Open

cfinterface and messaging #30

bdw429s opened this issue May 5, 2017 · 2 comments

Comments

@bdw429s
Copy link

bdw429s commented May 5, 2017

Testing the CLI command on the ColdBox source code (which still has some tags floating around) I noticed that interfaces don't work.

! Error: system\ioc\scopes\IScope.cfc
  Unable to convert tag: cfinterface to CFML Script
+  (Converted): system\ioc\scopes\IScope.cfc

Also, the messaging is confusing since it says it was unable to convert, but then says the file was converted (it wasn't).

@pfreitag
Copy link
Member

pfreitag commented May 5, 2017

Thanks -- yeah that is confusing I guess, it was unable to convert the <cfinterface> tag but it was probably able to convert any other CFML tags in there (like cffunction, etc) so it does not fail fully, it just wraps the tags it cannot convert in a comment.

@bdw429s
Copy link
Author

bdw429s commented May 5, 2017

Yeah, in that case it was the entire CFC :) I'd say just swap the green "success" message to something like a yellow "partially converted, please review" message. My eyes were scanning for green lines at first thinking they were the ones that were 100% good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants