Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String literals being converted #32

Open
KamasamaK opened this issue May 10, 2017 · 4 comments
Open

String literals being converted #32

KamasamaK opened this issue May 10, 2017 · 4 comments

Comments

@KamasamaK
Copy link

The convertOperators function does not discriminate between what is code and what is not, which results in the issue demonstrated below.

<cfset variables.message = "This is not supposed to be converted">
converts to
variables.message = "This != supposed to be converted";

@chapmandu
Copy link

chapmandu commented May 16, 2017

Additional examples:

<cfset foo = "I love my GT Falcon">
<cfset bar = "Rick and Morty">

converts to

foo = "I love my > Falcon";
bar = "Rick && Morty";

@pfreitag
Copy link
Member

Thanks for reporting this, for sure a bug that needs to be addressed.

@chapmandu
Copy link

Bump?

I've had a few gnarly instances when converting string literal SQL statements.. eg:

where = "userid = 1 AND isdeleted = 1"
becomes
where = "userid = 1 && isdeleted = 1"

Same with OR becomes ||

As always, appreciative of this awesome free tool.

@pfreitag
Copy link
Member

Another example:

<cfset variables.test = "this or that">

Haven't had the time to fix this yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants