Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom argument attributes not carried over #36

Open
pfreitag opened this issue Jan 30, 2019 · 3 comments
Open

Custom argument attributes not carried over #36

pfreitag opened this issue Jan 30, 2019 · 3 comments

Comments

@pfreitag
Copy link
Member

pfreitag commented Jan 30, 2019

Code such as:

<cfargument name="controller" inject="coldbox">

Does not pass the inject argument over.

Could be converted as:

any controller inject='coldbox'

Note that the type may be required in this case.

@KamasamaK
Copy link

I think it is fine, and personally preferred, to include the type when converting. I know this is beside the point, but the example conversion should not have required.

@pfreitag
Copy link
Member Author

Yeah I think it is ok to add any in that case too, thanks for offering your opinion. I removed required from the original comment.

@KamasamaK
Copy link

Possibly related to #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants