Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

securedrop.tests.functional.web_drivers: refactor to parameterize on driver class #7415

Open
cfm opened this issue Jan 16, 2025 · 1 comment

Comments

@cfm
Copy link
Member

cfm commented Jan 16, 2025

As I found out in https://gist.github.com/cfm/8a4dddcee3e993998ec4d68e123da89d, it would be trivial to refactor securedrop.tests.functional.web_drivers into a single _create_driver(driver_cls, **kwargs) function. tbselenium.utils.set_tbb_pref() works isomorphically on selenium.webdriver.firefox.webdriver.WebDriver as on tbselenium.tbdriver.TorBrowserDriver.

@cfm cfm changed the title securedrop.tests.functional.web_drivers: refactor to parameterize on driver type securedrop.tests.functional.web_drivers: refactor to parameterize on driver class Jan 16, 2025
@alberefe
Copy link

alberefe commented Feb 7, 2025

Hi, I'd like to help but I'm not sure if I'm understanding the issue. It is to create a unified function for creating the driver, firefox or tor, based on the class passed as argument, am I correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants