Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player.AddHardwareRule does not set IsHardwareRule flag #492

Open
arthurkehrwald opened this issue Nov 11, 2024 · 0 comments
Open

Player.AddHardwareRule does not set IsHardwareRule flag #492

arthurkehrwald opened this issue Nov 11, 2024 · 0 comments
Labels
refactoring Ugly code that needs to go

Comments

@arthurkehrwald
Copy link
Contributor

Player.AddHardwareRule calls _wirePlayer.AddWire(wireMapping);. The signature of that function is: internal void AddWire(WireMapping wireMapping, bool isHardwareRule = false) Since Player.AddHardwareRule does not pass an argument for the isHardwareRule argument, it will always have it's default value false. This seems wrong given the name of the function.
@freezy freezy added the refactoring Ugly code that needs to go label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Ugly code that needs to go
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freezy @arthurkehrwald