From da220c855b7bd5f2363e2c78bee85da5b169c3e4 Mon Sep 17 00:00:00 2001
From: Martin Fenner <martin@front-matter.io>
Date: Fri, 5 Apr 2024 18:23:19 +0200
Subject: [PATCH] fix utils function

---
 utils/utils.go      |  9 ++++-----
 utils/utils_test.go | 15 +++++++--------
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/utils/utils.go b/utils/utils.go
index fb09e89..4b0a673 100644
--- a/utils/utils.go
+++ b/utils/utils.go
@@ -1,9 +1,8 @@
 package utils
 
+import "fmt"
+
 // ISSN as URL
-func IssnAsUrl(issn string) *string {
-	if issn == nil {
-		return nil
-	}
-	return "https://portal.issn.org/resource/ISSN/" + issn
+func IssnAsUrl(issn string) string {
+	return fmt.Sprintf("https://portal.issn.org/resource/ISSN/%s", issn)
 }
diff --git a/utils/utils_test.go b/utils/utils_test.go
index 918ce1f..3f0dead 100644
--- a/utils/utils_test.go
+++ b/utils/utils_test.go
@@ -1,25 +1,24 @@
 package utils_test
 
 import (
+	"commonmeta/utils"
 	"testing"
-	"utils"
 )
 
 func TestIssnAsUrl(t *testing.T) {
 	t.Parallel()
 	type testCase struct {
-		issn string
-		want string
+		input string
+		want  string
 	}
 	testCases := []testCase{
-		{issn: "2146-8427", want: "https://portal.issn.org/resource/ISSN/2146-8427"},
-		{issn: nil, want: nil},
+		{input: "2146-8427", want: "https://portal.issn.org/resource/ISSN/2146-8427"},
 	}
 	for _, tc := range testCases {
-		got := utils.IssnAsUrl(tc.issn)
+		got := utils.IssnAsUrl(tc.input)
 		if tc.want != got {
-			t.Errorf("ISSN as URL(%f): want %f, got %f",
-				tc.issn, tc.want, got)
+			t.Errorf("ISSN as URL(%v): want %v, got %v",
+				tc.input, tc.want, got)
 		}
 	}
 }