-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux target deletes the [LinuxAndBSD] section of the project toml file #284
Comments
I think I realize what the issue is: fynx-cross uses fyne/[email protected], and the Linux and BSD section support wasn't added until. v2.4.0. (c.f. https://github.com/fyne-io/fyne/releases/tag/v2.4.0). So fyne is stripping out the section it doesn't know about. |
The metadata lookup functions are not shared between the projects. I think this also might be related to the duplicated (not in sync) metadata lookup handling? https://github.com/fyne-io/fyne-cross/tree/master/internal/metadata |
What's interesting is that building for linux on any arch causes the corruption, but not for darwin or windows, and
Given that the linux image is much older, I wonder if the bug was fixed somewhere between 6 and 14 months ago. I don't know what is involved, but maybe rebuilding the linux docker image would fix it. During that time the toml parsing package used (github.com/BurntSushi/toml) went from version 1.1.0 ro 1.3.2, and that seems a possible candidate. |
You can always try testing fyne-io/fyne-cross-images#55 if you think it is caused by the images |
Updating the linux docker image seems to do the trick. |
metadata has been updated in #286 |
The android target has a similar problem... trying to update the docker image for that one, but having problems |
In trying to work around this bug #267 I installed fyne-cross@develop, and while that bug is addressed, the bug where it removes the LinuxAndBSD section still occurs. I tried rebuilding the android image, but fyne-cross refuses to use it and instead fetching the broken image from docker hub. I'm not sure how to address this. |
Are you rebuilding the right image? Android uses a different image from all other targets. |
I've tried checking out the fyne-cross-images repo (both the main and lucor's) and running Is that not correct? |
I think I'm confused sorry. If it's the metadata issue then you need latest fyne-cross (develop) until there is a new release. |
I did use fyne-cross@develop, since that's the only version that currently works on MacOS, but it insists on pulling the old version of the android docker image even when I compile a new one, and the old image deletes that stanza in the metadata. |
Describe the bug:
When I use fyne-cross to build linux packages on Macos (and maybe other platforms), it removes the section of the project toml file
[LinuxAndBSD]
.To Reproduce:
Steps to reproduce the behaviour:
fyne-cross linux
Example code:
Device and debug info (please complete the following information):
Debug info
The text was updated successfully, but these errors were encountered: