Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check fewer components in grade entropy #9

Open
galenseilis opened this issue Mar 14, 2022 · 0 comments
Open

Check fewer components in grade entropy #9

galenseilis opened this issue Mar 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@galenseilis
Copy link
Owner

Let there be two vectors x and y where we wish to check if x < y. Currently estimators.grade_entropy checks every pair of components (x_i, y_i) but this is not necessary. Once there exists an i such that x_i > y_i, this guarantees that that x is not less than y. Stopping should occur here. This might be best-suited for a Cython extension since looping over the components will be slower in native Python than using NumPy broadcasting in many circumstances.

@galenseilis galenseilis added the enhancement New feature or request label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant