You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Let there be two vectors x and y where we wish to check if x < y. Currently estimators.grade_entropy checks every pair of components (x_i, y_i) but this is not necessary. Once there exists an i such that x_i > y_i, this guarantees that that x is not less than y. Stopping should occur here. This might be best-suited for a Cython extension since looping over the components will be slower in native Python than using NumPy broadcasting in many circumstances.
The text was updated successfully, but these errors were encountered:
Let there be two vectors x and y where we wish to check if x < y. Currently
estimators.grade_entropy
checks every pair of components (x_i, y_i) but this is not necessary. Once there exists an i such that x_i > y_i, this guarantees that that x is not less than y. Stopping should occur here. This might be best-suited for a Cython extension since looping over the components will be slower in native Python than using NumPy broadcasting in many circumstances.The text was updated successfully, but these errors were encountered: