From e511b1f92dadc7215d7b9de00675018c7a50d714 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Wed, 25 Oct 2023 15:28:40 +0200 Subject: [PATCH 01/16] updated submission file --- CRAN-SUBMISSION | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION index 6703c597..1d64f280 100644 --- a/CRAN-SUBMISSION +++ b/CRAN-SUBMISSION @@ -1,3 +1,3 @@ Version: 4.4 -Date: 2023-10-12 11:08:56 UTC -SHA: 8c228455a5dd87a4cb749a9bf502d5b5238cfd0a +Date: 2023-10-25 13:28:02 UTC +SHA: aae2737b300a2f558e2fea165d8febefedf1efbc From c585ee8af1b09d448322bf6dfb909d44cdc31662 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 11:28:01 +0200 Subject: [PATCH 02/16] unwrapped example, 1.1sec runtime --- R/calib_sofun.R | 2 -- man/calib_sofun.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/calib_sofun.R b/R/calib_sofun.R index c5833a7c..67a6f904 100644 --- a/R/calib_sofun.R +++ b/R/calib_sofun.R @@ -44,7 +44,6 @@ #' @import GenSA BayesianTools #' #' @examples -#' \donttest{ #' # Fix model parameters that won't be calibrated #' params_fix <- list( #' kphio_par_a = 0, @@ -84,7 +83,6 @@ #' par_fixed = params_fix, #' targets = c("gpp") #' ) -#' } calib_sofun <- function( drivers, diff --git a/man/calib_sofun.Rd b/man/calib_sofun.Rd index 503a3955..4ee95d41 100644 --- a/man/calib_sofun.Rd +++ b/man/calib_sofun.Rd @@ -55,7 +55,6 @@ This is the main function that handles the calibration of SOFUN model parameters. } \examples{ -\donttest{ # Fix model parameters that won't be calibrated params_fix <- list( kphio_par_a = 0, @@ -96,4 +95,3 @@ settings <- list( targets = c("gpp") ) } -} From 3622878ebd20e39687c6e4be8743a873fc428fc0 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 11:29:24 +0200 Subject: [PATCH 03/16] unwrap example, 2sec elapsed --- R/cost_likelihood_biomee.R | 2 -- man/cost_likelihood_biomee.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/cost_likelihood_biomee.R b/R/cost_likelihood_biomee.R index 79a1ef4a..01b77a5d 100644 --- a/R/cost_likelihood_biomee.R +++ b/R/cost_likelihood_biomee.R @@ -29,7 +29,6 @@ #' @export #' #' @examples -#' \donttest{ #' # Compute the likelihood for a set of #' # BiomeE model parameter values #' # and the example data @@ -40,7 +39,6 @@ #' drivers = biomee_gs_leuning_drivers, #' targets = c("GPP") #' ) -#' } cost_likelihood_biomee <- function( par, diff --git a/man/cost_likelihood_biomee.Rd b/man/cost_likelihood_biomee.Rd index 9b0e4f95..d44cb666 100644 --- a/man/cost_likelihood_biomee.Rd +++ b/man/cost_likelihood_biomee.Rd @@ -40,7 +40,6 @@ The optimization should be run using \code{BayesianTools}, so the likelihood is maximized. } \examples{ -\donttest{ # Compute the likelihood for a set of # BiomeE model parameter values # and the example data @@ -52,4 +51,3 @@ cost_likelihood_biomee( targets = c("GPP") ) } -} From 13771f327949212ce0d56ad1c247d13ad0277d54 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 11:30:41 +0200 Subject: [PATCH 04/16] unwrap example, elapsed 0.04sec --- R/cost_likelihood_pmodel.R | 2 -- man/cost_likelihood_pmodel.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/cost_likelihood_pmodel.R b/R/cost_likelihood_pmodel.R index f5d39f73..5aac9304 100644 --- a/R/cost_likelihood_pmodel.R +++ b/R/cost_likelihood_pmodel.R @@ -51,7 +51,6 @@ #' @export #' #' @examples -#' \donttest{ #' # Compute the likelihood for a set of #' # model parameter values involved in the #' # temperature dependence of kphio @@ -71,7 +70,6 @@ #' kc_jmax = 0.41 #' ) #' ) -#' } cost_likelihood_pmodel <- function( par, # model parameters & error terms for each target diff --git a/man/cost_likelihood_pmodel.Rd b/man/cost_likelihood_pmodel.Rd index 559a147b..d206d812 100644 --- a/man/cost_likelihood_pmodel.Rd +++ b/man/cost_likelihood_pmodel.Rd @@ -73,7 +73,6 @@ when the date of a trait measurement is available, it will be compared to the trait value predicted on that date. } \examples{ -\donttest{ # Compute the likelihood for a set of # model parameter values involved in the # temperature dependence of kphio @@ -94,4 +93,3 @@ cost_likelihood_pmodel( ) ) } -} From 921a0a8b24d87c27097cad753033c656026234bb Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 12:00:33 +0200 Subject: [PATCH 05/16] Add Laura and Ensheng as contributors --- DESCRIPTION | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/DESCRIPTION b/DESCRIPTION index f14797ca..52f7032f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -20,6 +20,18 @@ Authors@R: c( email = "pepa.aran@gmail.com", comment = c(ORCID = "0009-0006-7176-2311"), role = c("aut")), + person( + family = "Marqués", + given = "Laura", + email = "lauramarqueslopez@gmail.com", + comment = c(ORCID = "0000-0002-3593-5557"), + role = c("ctb")), + person( + family = "Weng", + given = "Ensheng", + email = "wengensheng@gmail.com", + comment = c(ORCID = "0000-0002-1858-4847"), + role = c("ctb")), person(given = "Geocomputation and Earth Observation, University of Bern", role = c("cph", "fnd")) ) From 6f8f9b898582bc52f68e525ba66f171afc428a4c Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 12:02:22 +0200 Subject: [PATCH 06/16] unwrap example, 2sec runtime --- R/cost_rmse_biomee.R | 2 -- man/cost_rmse_biomee.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/cost_rmse_biomee.R b/R/cost_rmse_biomee.R index b675ab30..90c208bb 100644 --- a/R/cost_rmse_biomee.R +++ b/R/cost_rmse_biomee.R @@ -24,7 +24,6 @@ #' @export #' #' @examples -#' \donttest{ #' # Compute RMSE for a set of #' # model parameter values #' # and example data @@ -33,7 +32,6 @@ #' obs = biomee_validation_2, #' drivers = biomee_gs_leuning_drivers #' ) -#' } cost_rmse_biomee <- function( par, diff --git a/man/cost_rmse_biomee.Rd b/man/cost_rmse_biomee.Rd index 5f3549da..78bc062d 100644 --- a/man/cost_rmse_biomee.Rd +++ b/man/cost_rmse_biomee.Rd @@ -33,7 +33,6 @@ computes the RMSE for the biomee model fitting target variables \code{'GPP','LAI','Density'} and \code{'Biomass'} for a given set of parameters. } \examples{ -\donttest{ # Compute RMSE for a set of # model parameter values # and example data @@ -43,4 +42,3 @@ cost_rmse_biomee( drivers = biomee_gs_leuning_drivers ) } -} From 9a6132ca8743982b4c5dc631ab3ec02f99766440 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 15:22:59 +0200 Subject: [PATCH 07/16] unwrap example, 0.04sec elapsed --- R/cost_rmse_pmodel.R | 2 -- man/cost_rmse_pmodel.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/cost_rmse_pmodel.R b/R/cost_rmse_pmodel.R index 5ab7f249..7236bfb0 100644 --- a/R/cost_rmse_pmodel.R +++ b/R/cost_rmse_pmodel.R @@ -48,7 +48,6 @@ #' @export #' #' @examples -#' \donttest{ #' # Compute RMSE for a set #' # of model parameter values #' # and example data @@ -66,7 +65,6 @@ #' kc_jmax = 0.41 #' ) #' ) -#' } cost_rmse_pmodel <- function( par, # ordered vector of model parameters diff --git a/man/cost_rmse_pmodel.Rd b/man/cost_rmse_pmodel.Rd index 6662e02f..ca897fa8 100644 --- a/man/cost_rmse_pmodel.Rd +++ b/man/cost_rmse_pmodel.Rd @@ -72,7 +72,6 @@ when the date of a trait measurement is available, it will be compared to the trait value predicted on that date. } \examples{ -\donttest{ # Compute RMSE for a set # of model parameter values # and example data @@ -91,4 +90,3 @@ cost_rmse_pmodel( ) ) } -} From e282befa9b3817fa456895f72d0396d0e51a7588 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 15:24:38 +0200 Subject: [PATCH 08/16] remove dontest --- R/init_dates_dataframe.R | 2 -- man/init_dates_dataframe.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/init_dates_dataframe.R b/R/init_dates_dataframe.R index 5255989b..1192075a 100644 --- a/R/init_dates_dataframe.R +++ b/R/init_dates_dataframe.R @@ -27,10 +27,8 @@ #' @export #' #' @examples -#' \donttest{ #' ddf <- init_dates_dataframe( 2000, 2003, startmoy=1, startdoy=1, #' freq="days", endmoy=12, enddom=31, noleap=FALSE ) -#' } init_dates_dataframe <- function( yrstart, diff --git a/man/init_dates_dataframe.Rd b/man/init_dates_dataframe.Rd index b4613c6e..837c81a7 100644 --- a/man/init_dates_dataframe.Rd +++ b/man/init_dates_dataframe.Rd @@ -51,8 +51,6 @@ in \code{'yyyy-mm-dd'} format. Intervals of dates are specified by argument \code{'freq'}. } \examples{ -\donttest{ ddf <- init_dates_dataframe( 2000, 2003, startmoy=1, startdoy=1, freq="days", endmoy=12, enddom=31, noleap=FALSE ) } -} From 63022a4de65d55ccabe9deb77a598df0105cf740 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 15:25:56 +0200 Subject: [PATCH 09/16] remove donttest, runtime 2sec --- R/run_biomee_f_bysite.R | 2 -- man/run_biomee_f_bysite.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/run_biomee_f_bysite.R b/R/run_biomee_f_bysite.R index 6ba3d9b3..148d1282 100644 --- a/R/run_biomee_f_bysite.R +++ b/R/run_biomee_f_bysite.R @@ -352,7 +352,6 @@ #' } #' #' @examples -#' \donttest{ #' # Example BiomeE model run #' #' # Use example drivers data @@ -370,7 +369,6 @@ #' init_cohort = drivers$init_cohort[[1]], #' init_soil = drivers$init_soil[[1]] #' ) -#' } run_biomee_f_bysite <- function( sitename, diff --git a/man/run_biomee_f_bysite.Rd b/man/run_biomee_f_bysite.Rd index 6540d1d0..ea48125c 100644 --- a/man/run_biomee_f_bysite.Rd +++ b/man/run_biomee_f_bysite.Rd @@ -378,7 +378,6 @@ Model output is provided as a list, with elements: Call to the biomee Fortran model } \examples{ -\donttest{ # Example BiomeE model run # Use example drivers data @@ -397,4 +396,3 @@ mod_output <- run_biomee_f_bysite( init_soil = drivers$init_soil[[1]] ) } -} From e997afa9e80abec2a31c81f52368efac31a0fb06 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 15:27:04 +0200 Subject: [PATCH 10/16] unwrap example, 0.02sec --- R/run_pmodel_f_bysite.R | 2 -- man/run_pmodel_f_bysite.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/run_pmodel_f_bysite.R b/R/run_pmodel_f_bysite.R index 3ab40b4d..9fa90a89 100644 --- a/R/run_pmodel_f_bysite.R +++ b/R/run_pmodel_f_bysite.R @@ -130,7 +130,6 @@ #' @useDynLib rsofun #' #' @examples -#' \donttest{ #' # Define model parameter values from previous work #' params_modl <- list( #' kphio = 0.04998, # setup ORG in Stocker et al. 2020 GMD @@ -153,7 +152,6 @@ #' forcing = p_model_drivers$forcing[[1]], #' params_modl = params_modl #' ) -#' } run_pmodel_f_bysite <- function( sitename, diff --git a/man/run_pmodel_f_bysite.Rd b/man/run_pmodel_f_bysite.Rd index 1b43fb60..32386504 100644 --- a/man/run_pmodel_f_bysite.Rd +++ b/man/run_pmodel_f_bysite.Rd @@ -149,7 +149,6 @@ Hence, the FULL calibration setup cannot be exactly replicated. } \examples{ -\donttest{ # Define model parameter values from previous work params_modl <- list( kphio = 0.04998, # setup ORG in Stocker et al. 2020 GMD @@ -173,4 +172,3 @@ mod_output <- run_pmodel_f_bysite( params_modl = params_modl ) } -} From 0e9454e12fb7543fb8eb81e34cd4dd5b5d295bc2 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 15:28:14 +0200 Subject: [PATCH 11/16] unwrap example, 2.08sec --- R/runread_biomee_f.R | 2 -- man/runread_biomee_f.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/runread_biomee_f.R b/R/runread_biomee_f.R index d077dddc..6b0d2d9a 100644 --- a/R/runread_biomee_f.R +++ b/R/runread_biomee_f.R @@ -18,12 +18,10 @@ #' @export #' #' @examples -#' \donttest{ #' # Example BiomeE model run #' #' mod_output <- runread_biomee_f( #' drivers = biomee_gs_leuning_drivers) -#' } runread_biomee_f <- function( drivers, diff --git a/man/runread_biomee_f.Rd b/man/runread_biomee_f.Rd index 51b887b9..98e7dd76 100644 --- a/man/runread_biomee_f.Rd +++ b/man/runread_biomee_f.Rd @@ -29,10 +29,8 @@ description of the BiomeE output variables. Runs the BiomeE model and loads output in once. } \examples{ -\donttest{ # Example BiomeE model run mod_output <- runread_biomee_f( drivers = biomee_gs_leuning_drivers) } -} From c3ecbd972c3f463540eccd2b4fdd3c29d7168d4e Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 15:29:01 +0200 Subject: [PATCH 12/16] unwrap, 0.03sec --- R/runread_pmodel_f.R | 2 -- man/runread_pmodel_f.Rd | 2 -- 2 files changed, 4 deletions(-) diff --git a/R/runread_pmodel_f.R b/R/runread_pmodel_f.R index 61471b16..5120e706 100644 --- a/R/runread_pmodel_f.R +++ b/R/runread_pmodel_f.R @@ -77,7 +77,6 @@ #' exactly replicated. #' #' @examples -#' \donttest{ #' # Define model parameter values from previous work #' params_modl <- list( #' kphio = 0.04998, # setup ORG in Stocker et al. 2020 GMD @@ -95,7 +94,6 @@ #' output <- rsofun::runread_pmodel_f( #' drivers = rsofun::p_model_drivers, #' par = params_modl) -#' } runread_pmodel_f <- function( drivers, diff --git a/man/runread_pmodel_f.Rd b/man/runread_pmodel_f.Rd index a81c4d95..6c50b38e 100644 --- a/man/runread_pmodel_f.Rd +++ b/man/runread_pmodel_f.Rd @@ -90,7 +90,6 @@ Hence, the FULL calibration setup cannot be exactly replicated. } \examples{ -\donttest{ # Define model parameter values from previous work params_modl <- list( kphio = 0.04998, # setup ORG in Stocker et al. 2020 GMD @@ -109,4 +108,3 @@ output <- rsofun::runread_pmodel_f( drivers = rsofun::p_model_drivers, par = params_modl) } -} From 20dc46fd436794d692455776af9f80b060b90b2c Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Fri, 27 Oct 2023 17:02:37 +0200 Subject: [PATCH 13/16] update comments --- cran-comments.md | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 90a66fdf..d82ad5ec 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -3,16 +3,8 @@ Dear CRAN team, This is the re-submission of the {rsofun} package. We have addressed the following concerns voiced by Benjamin Altman: -- Corrected the software naming in package title and description. -- Added a \value field to all the exported functions, explaining the object returned - by each function. -- Removed \dontrun statements in the documentation examples, now \donttest - is used for examples that have long runtimes. -- Included license and copyright statements in a COPYING file. The original authors - of the software borrowed for this package were contacted and permissions to use - parts of their code were discussed, as well as the copyright and license that - accompany their code. The direct authors of this package are listed in the - DESCRIPTION file. +- Removed \donttest statements in the documentation examples that took < 5 min to run. +- Included Ensheng Weng and Laura Marqués as package contributors. --- From ad30b7b291ddbdaaa62ff1729f7bd4a6669bc9c2 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Mon, 30 Oct 2023 10:54:06 +0100 Subject: [PATCH 14/16] wrap example in donttest --- R/cost_likelihood_biomee.R | 2 ++ R/cost_rmse_biomee.R | 2 ++ R/run_biomee_f_bysite.R | 2 ++ R/runread_biomee_f.R | 5 ++++- man/cost_likelihood_biomee.Rd | 2 ++ man/cost_rmse_biomee.Rd | 2 ++ man/run_biomee_f_bysite.Rd | 2 ++ man/runread_biomee_f.Rd | 5 ++++- 8 files changed, 20 insertions(+), 2 deletions(-) diff --git a/R/cost_likelihood_biomee.R b/R/cost_likelihood_biomee.R index 01b77a5d..79a1ef4a 100644 --- a/R/cost_likelihood_biomee.R +++ b/R/cost_likelihood_biomee.R @@ -29,6 +29,7 @@ #' @export #' #' @examples +#' \donttest{ #' # Compute the likelihood for a set of #' # BiomeE model parameter values #' # and the example data @@ -39,6 +40,7 @@ #' drivers = biomee_gs_leuning_drivers, #' targets = c("GPP") #' ) +#' } cost_likelihood_biomee <- function( par, diff --git a/R/cost_rmse_biomee.R b/R/cost_rmse_biomee.R index 90c208bb..b675ab30 100644 --- a/R/cost_rmse_biomee.R +++ b/R/cost_rmse_biomee.R @@ -24,6 +24,7 @@ #' @export #' #' @examples +#' \donttest{ #' # Compute RMSE for a set of #' # model parameter values #' # and example data @@ -32,6 +33,7 @@ #' obs = biomee_validation_2, #' drivers = biomee_gs_leuning_drivers #' ) +#' } cost_rmse_biomee <- function( par, diff --git a/R/run_biomee_f_bysite.R b/R/run_biomee_f_bysite.R index 148d1282..6ba3d9b3 100644 --- a/R/run_biomee_f_bysite.R +++ b/R/run_biomee_f_bysite.R @@ -352,6 +352,7 @@ #' } #' #' @examples +#' \donttest{ #' # Example BiomeE model run #' #' # Use example drivers data @@ -369,6 +370,7 @@ #' init_cohort = drivers$init_cohort[[1]], #' init_soil = drivers$init_soil[[1]] #' ) +#' } run_biomee_f_bysite <- function( sitename, diff --git a/R/runread_biomee_f.R b/R/runread_biomee_f.R index 6b0d2d9a..deef8062 100644 --- a/R/runread_biomee_f.R +++ b/R/runread_biomee_f.R @@ -18,10 +18,13 @@ #' @export #' #' @examples +#' \donttest{ #' # Example BiomeE model run #' #' mod_output <- runread_biomee_f( -#' drivers = biomee_gs_leuning_drivers) +#' drivers = biomee_gs_leuning_drivers +#' ) +#' } runread_biomee_f <- function( drivers, diff --git a/man/cost_likelihood_biomee.Rd b/man/cost_likelihood_biomee.Rd index d44cb666..9b0e4f95 100644 --- a/man/cost_likelihood_biomee.Rd +++ b/man/cost_likelihood_biomee.Rd @@ -40,6 +40,7 @@ The optimization should be run using \code{BayesianTools}, so the likelihood is maximized. } \examples{ +\donttest{ # Compute the likelihood for a set of # BiomeE model parameter values # and the example data @@ -51,3 +52,4 @@ cost_likelihood_biomee( targets = c("GPP") ) } +} diff --git a/man/cost_rmse_biomee.Rd b/man/cost_rmse_biomee.Rd index 78bc062d..5f3549da 100644 --- a/man/cost_rmse_biomee.Rd +++ b/man/cost_rmse_biomee.Rd @@ -33,6 +33,7 @@ computes the RMSE for the biomee model fitting target variables \code{'GPP','LAI','Density'} and \code{'Biomass'} for a given set of parameters. } \examples{ +\donttest{ # Compute RMSE for a set of # model parameter values # and example data @@ -42,3 +43,4 @@ cost_rmse_biomee( drivers = biomee_gs_leuning_drivers ) } +} diff --git a/man/run_biomee_f_bysite.Rd b/man/run_biomee_f_bysite.Rd index ea48125c..6540d1d0 100644 --- a/man/run_biomee_f_bysite.Rd +++ b/man/run_biomee_f_bysite.Rd @@ -378,6 +378,7 @@ Model output is provided as a list, with elements: Call to the biomee Fortran model } \examples{ +\donttest{ # Example BiomeE model run # Use example drivers data @@ -396,3 +397,4 @@ mod_output <- run_biomee_f_bysite( init_soil = drivers$init_soil[[1]] ) } +} diff --git a/man/runread_biomee_f.Rd b/man/runread_biomee_f.Rd index 98e7dd76..aed8d5f1 100644 --- a/man/runread_biomee_f.Rd +++ b/man/runread_biomee_f.Rd @@ -29,8 +29,11 @@ description of the BiomeE output variables. Runs the BiomeE model and loads output in once. } \examples{ +\donttest{ # Example BiomeE model run mod_output <- runread_biomee_f( - drivers = biomee_gs_leuning_drivers) + drivers = biomee_gs_leuning_drivers +) +} } From 50aa48c8f7cb621dcd99b77ccd6ea6d8e8ca13ba Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Mon, 30 Oct 2023 10:55:32 +0100 Subject: [PATCH 15/16] update --- cran-comments.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index d82ad5ec..331b890f 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,10 +1,10 @@ Dear CRAN team, This is the re-submission of the {rsofun} package. We have addressed the following -concerns voiced by Benjamin Altman: +concerns flagged by the automatic checks: -- Removed \donttest statements in the documentation examples that took < 5 min to run. -- Included Ensheng Weng and Laura Marqués as package contributors. +- Wrapped examples running the BiomeE model in \donttest because they took 16 sec to run in the Windows pre-test. +- Reviewed DESCRIPTION file for misspelled words. The NOTE in the pre-tests is a false positive. --- From 9c1234b1877d5ba67356648f6c020e4e593f9f04 Mon Sep 17 00:00:00 2001 From: Pepa Aran Paredes Date: Mon, 30 Oct 2023 15:15:17 +0100 Subject: [PATCH 16/16] latest submission file --- CRAN-SUBMISSION | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CRAN-SUBMISSION b/CRAN-SUBMISSION index 1d64f280..089be14a 100644 --- a/CRAN-SUBMISSION +++ b/CRAN-SUBMISSION @@ -1,3 +1,3 @@ Version: 4.4 -Date: 2023-10-25 13:28:02 UTC -SHA: aae2737b300a2f558e2fea165d8febefedf1efbc +Date: 2023-10-30 09:56:10 UTC +SHA: 50aa48c8f7cb621dcd99b77ccd6ea6d8e8ca13ba