Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display toolbar in widget view #397

Closed
mfisher87 opened this issue Jan 28, 2025 · 5 comments · Fixed by #419
Closed

Display toolbar in widget view #397

mfisher87 opened this issue Jan 28, 2025 · 5 comments · Fixed by #419
Labels
enhancement New feature or request

Comments

@mfisher87
Copy link
Member

I think it would be valuable to display the toolbar in the widget view. Our wonderful tools for data exploration (adding layers for context, identifying features) are available via the toolbar! What do you think?

Looks like this right now:

Image

@mfisher87 mfisher87 added the enhancement New feature or request label Jan 28, 2025
@brichet
Copy link
Collaborator

brichet commented Jan 28, 2025

I believe that this is related to #340

Maybe we should add an optional toolbar in the widget, that would not be displayed when the project file is opened as a DocumentWidget (main area widget).

we should also take care of tracking these widgets like the DocumentWidget, so as to link them to the side panels as well.

@mfisher87
Copy link
Member Author

I was thinking some features like the identify tool would be useful no matter what. Perhaps it could be optionally disabled (opt-out) instead of optionally enabled (opt-in)?

@martinRenou
Copy link
Member

martinRenou commented Jan 29, 2025

I was thinking some features like the identify tool would be useful no matter what

I agree. Actually I'd vote for having the toolbar always there. It's not like it's taking so much space that users won't want it.

How about we split the work from #340 in two PRs.

  • One that adds the toolbar + enables the left/right panels for all JupyterGIS cell outputs in the Python API
  • Another one that adds the new geo_debug routine in the Python API
    ?

@mfisher87
Copy link
Member Author

How about we split the work from #340 in two PRs.

Agreed!

@brichet
Copy link
Collaborator

brichet commented Jan 30, 2025

  • One that adds the toolbar + enables the left/right panels for all JupyterGIS cell outputs in the Python API

I can take a look at this part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants