Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging message is unrendered on a webhook call #3660

Open
pohmelie opened this issue Oct 15, 2024 · 3 comments
Open

Logging message is unrendered on a webhook call #3660

pohmelie opened this issue Oct 15, 2024 · 3 comments

Comments

@pohmelie
Copy link

How do you use Sentry?

Self-hosted/on-premise

Version

2.9.0

Steps to Reproduce

We updated self hosted sentry to version 24.8.0 and after that logging integration do not render logging message. So we have a template in a sentry web-ui and webhook call instead of rendered message. For exampe:

logger.error("task for news source %s returned empty result %s", news_source, result)
logger.error(f"[debug] task for news source {news_source} returned empty result {result}")

This leads to 2 messages in sentry:

  • task for news source %s returned empty result %s
  • [debug] task for news source binance_api_changelog_spot returned empty result None

So, only force-rendered via f-string message is correct. Not sure if it is relative to sentry python sdk, or self-hosted sentry itself. Previous version 23.x.x was correct for this. More to say, some messages are rendered correctly. For example with %d. In the example above news_source is StrEnum and result is None.

Expected Result

Actual Result

@sl0thentr0py
Copy link
Member

@pohmelie can you paste the output of this 'View Json' from one of those message events from your Sentry instance.

Image

I'm interested in what this logentry field looks like in your event payload.

Image

@sl0thentr0py sl0thentr0py self-assigned this Oct 16, 2024
@sl0thentr0py sl0thentr0py added the Type: Bug Something isn't working label Oct 16, 2024
@pohmelie
Copy link
Author

@sl0thentr0py
This is all fields under logentry:
Image

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Oct 21, 2024

@pohmelie Would you be able to post the entire JSON? That would help me determine whether this problem originates in the SDK or the self-hosted backend.

FWIW, I was not able to reproduce this with the latest Sentry SDK version and SaaS Sentry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Community
Development

No branches or pull requests

3 participants