Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: llama-impl.h should be private #11630

Open
mofosyne opened this issue Feb 3, 2025 · 0 comments
Open

Refactor: llama-impl.h should be private #11630

mofosyne opened this issue Feb 3, 2025 · 0 comments

Comments

@mofosyne
Copy link
Collaborator

mofosyne commented Feb 3, 2025

Background Description

First highlighted: #11596

Initial PR: #11617

slaren suggests a better fix #11617 (comment)

Possible Refactor Approaches

target_include_directories(llama PUBLIC . ../include ../common)

Should be set to private according to slaren
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mofosyne