Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple diacritics render on _next_ character in Windows Terminal #260

Open
Jaykul opened this issue Oct 17, 2024 · 1 comment
Open

Multiple diacritics render on _next_ character in Windows Terminal #260

Jaykul opened this issue Oct 17, 2024 · 1 comment
Milestone

Comments

@Jaykul
Copy link

Jaykul commented Oct 17, 2024

The first screenshot here is Cascadia Code and the second is Monaspace Neon, in the preview release of Windows Terminal.

I'm using the same diacritic three times just for the demo, because if I use two or more different diacritic marks, they all get rendered on top of each other (and in the wrong space), and it's just a mess.

  1. The diacritics should be on the a, not on the b (and if I only have one, it woks, but 2 or more go on the next character)
  2. If there's more than one diacritic, I expect them to stack, not overlap.

image
image

Of course, this might be a Windows Terminal bug ... but it's working OK with Cascadia Code in the same app.

Here's another example, using both accent marks. Again, Consolas first:
image
image

@kenmcd
Copy link

kenmcd commented Oct 18, 2024

In Cascadia Code there are anchors on the bottom, and on the top, of the ~ diacritics - so they can stack, because they have anchors to attach to.
In Monaspace Neon it appears there are no anchors on the ~ diacritics at all.
So the second diacritic has no way to attach to the top of the previous one and just ends up floating.

Only looked at tildecomb and tildecomb.case, but I assume it is the same with the other diacritics.

Actually the shaper probably converts the a plus the first tildecomb into atilde () and then tries to stack the other two on top of that. ã̃̃

In Monaspace the atilde also does not have a Top anchor.
So it also needs a Top anchor (and many other characters do too).
And Monaspace also needs to add the anchors to the diacritics.

@heathercran heathercran added this to the 1.2 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants