Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command 'Add to .gitpod.yml' resulted in an error (Cannot read properties of undefined (reading 'trim')) #15353

Closed
gengjiawen opened this issue Dec 15, 2022 · 9 comments
Assignees
Labels

Comments

@gengjiawen
Copy link
Contributor

Bug description

Can't add .gitpod.yml from menu.

Steps to reproduce

https://github.com/yue/yue

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@gengjiawen gengjiawen added the type: bug Something isn't working label Dec 15, 2022
@jeanp413 jeanp413 moved this to Scheduled in 🚀 IDE Team Dec 19, 2022
@filiptronicek
Copy link
Member

Hi there @gengjiawen 👋! Could you please add more info about the extensions you're trying to add (along with the output of gp info)? I just tried opening a workspace with your mentioned repo and it seems I can add extensions from the context menu without a problem.

@filiptronicek filiptronicek self-assigned this Jan 2, 2023
@filiptronicek
Copy link
Member

The code issue is most likely originating in the add command itself here.

@jeanp413
Copy link
Member

jeanp413 commented Feb 3, 2023

@gengjiawen can you still repro this?

@gengjiawen
Copy link
Contributor Author

@gengjiawen can you still repro this?

Yeap. Basically every repo. eg: https://gitpod.io/#https://github.com/hugozanini/yolov7-tfjs

It's really disappointing it's still not fixed after so long.

@jeanp413
Copy link
Member

jeanp413 commented Feb 4, 2023

Thanks, I can repro.

The Add to .gitpod.yml is not meant to be run from the command pallete, instead it's used from the context menu when right clicking over an extension entry (it receives the extension id as argument) so I will remove it from the command pallete.

Is your intention of invoking that command from the command pallete to just open the .gitpod.yml file? In that case I will add a new command Open .gitpod.yml.

image

@jeanp413
Copy link
Member

jeanp413 commented Feb 6, 2023

Note to myself: verify if it does work in problem panel

@filiptronicek
Copy link
Member

@jeanp413 do you mean an Add to .gitpod.yml command in the problems panel? I could not find it, but got another warning. That quickfix seems to be doing interesting stuff:
https://www.loom.com/share/d5804fea82fc4109b607c30b543d69e0

@jeanp413
Copy link
Member

jeanp413 commented Feb 6, 2023

do you mean an Add to .gitpod.yml command in the problems panel? I could not find it,

Looks it's fine then, problems panel and quick fix uses different command

That quickfix seems to be doing interesting stuff:

yeah I saw that too =S

@jeanp413
Copy link
Member

Closing this, Add to .gitpod.yml is no longer in the command pallete, for the cases when it breaks gitpod.yml I created another issue #16352

@github-project-automation github-project-automation bot moved this from Scheduled to Done in 🚀 IDE Team Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants