Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For BigQuery we should consider copying primary key contraints #135

Open
nj1973 opened this issue Mar 25, 2024 · 0 comments
Open

For BigQuery we should consider copying primary key contraints #135

nj1973 opened this issue Mar 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nj1973
Copy link
Collaborator

nj1973 commented Mar 25, 2024

Primary key constraints are not enforced therefore there should not be a performance overhead when inserting. BigQuery documentation states:

"
You should specify key constraints in the table schema when table data satisfies the data integrity requirements of primary key or foreign key constraints. The query engine can use the key constraints to optimize query plans.
"

Although there is a counter argument that we do not do this for any other SQL engine, it is left up to the customer to apply constraints. So perhaps this is overstepping the mark.

I'm logging this for discussion in the future.

@nj1973 nj1973 added the enhancement New feature or request label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant