Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to support OFFLOAD_LOGDIR on GCS #198

Closed
nj1973 opened this issue Jun 14, 2024 · 0 comments · Fixed by #219 or #230
Closed

Tests to support OFFLOAD_LOGDIR on GCS #198

nj1973 opened this issue Jun 14, 2024 · 0 comments · Fixed by #219 or #230
Assignees
Labels
tests Issues relates only to tests

Comments

@nj1973
Copy link
Collaborator

nj1973 commented Jun 14, 2024

Issue #177 added support for logs to GCS, however it did not add support for running our tests with OFFLOAD_LOGDIR set to a GCS location. This was because another issue had changed most of the tests and this work also required a mass edit to the same files.

I decided it made sense to postpone this part, seeing as it is internal to developer processes, to avoid a lot of unnecessary chore.

To do:

  • Done: Change all tests that use get_test_messages to use the context manager version instead, get_test_messages_ctx
  • Up to now we wanted tests to include child offloads in the same log file as the test, this doesn't work for GCS logs, we need the offload log to be complete and closed so the test can open and interrogate it. Need to review how to do this in scenario_runner.run_offload.
@nj1973 nj1973 added this to the 2024-07 Release milestone Jun 14, 2024
@nj1973 nj1973 self-assigned this Jun 14, 2024
@nj1973 nj1973 added the tests Issues relates only to tests label Jul 9, 2024
@nj1973 nj1973 linked a pull request Jul 18, 2024 that will close this issue
@nj1973 nj1973 reopened this Jul 29, 2024
@nj1973 nj1973 linked a pull request Sep 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues relates only to tests
Projects
None yet
1 participant