Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flash message cookie is escaped twice #33372

Closed
Zettat123 opened this issue Jan 24, 2025 · 3 comments
Closed

Flash message cookie is escaped twice #33372

Zettat123 opened this issue Jan 24, 2025 · 3 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@Zettat123
Copy link
Contributor

Description

This issue is from #33298 (comment) . I'm not sure if it's a bug.

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

command

Database

None
@Zettat123 Zettat123 mentioned this issue Jan 24, 2025
Merged
@wxiaoguang
Copy link
Contributor

I do not think it is a bug.

When using the value, it will also be decoded twice.

@wxiaoguang wxiaoguang added issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail and removed type/bug labels Jan 24, 2025
@Zettat123
Copy link
Contributor Author

I do not think it is a bug.

When using the value, it will also be decoded twice.

Thanks for your explanation. Looks like the test code was incorrect. I fixed it in #33298 as well.

@wxiaoguang
Copy link
Contributor

Actually, I think you need this: Refactor context flash msg #33375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wxiaoguang @Zettat123