Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

Review and merge API breaking changes #8

Open
2 tasks
ivy opened this issue Dec 6, 2017 · 5 comments
Open
2 tasks

Review and merge API breaking changes #8

ivy opened this issue Dec 6, 2017 · 5 comments

Comments

@ivy
Copy link

ivy commented Dec 6, 2017

There are some open pull requests that make changes to public interfaces:

@pedromorgan: Could we make a next branch where we can stage these changes for a future v3 release branch?

@ivy
Copy link
Author

ivy commented Dec 6, 2017

We should also have a discussion about improving the public API to be more idiomatic/ergonomic.

@arbarlow
Copy link

👋 Hi, I wrote #78 but never heard back. Happy to change the methods, contribute and discuss the api methods as well, as I and my company use this package extensively!

@ivy
Copy link
Author

ivy commented Dec 18, 2017

@arbarlow Thanks for reaching out! I'd be very interested in a pull request against the next branch to add AttachFile and EmbedFile methods to Message.

@RangelReale
Copy link

I am going to need modifying this library too, but I saw that the "next" branch is behind the v2 one, we should send pull requests to v2 or next?

@jkak
Copy link

jkak commented May 24, 2018

I also need to Accept io.Reader for Attach and Embed (go-gomail#78). but there is no progress in v2 or next branch.

diamondburned pushed a commit to diamondburned/gomail that referenced this issue Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants