Add a run SCons option to run the engine binary after a build
#102550
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
scons-add-run-option
branch
6 times, most recently
from
0a0ee5c to
cdb6d53
Compare
Ivorforce
reviewed
Feb 7, 2025
| print("-" * 80 + f"\nBuild successful, running: {env['bin_path']} {env['run']}\n" + "-" * 80) | ||
| try: | ||
| # Allow using `~` as a shorthand for `$HOME` on all platforms. | ||
| subprocess.run([env["bin_path"], *env["run"].replace("~", os.environ["HOME"]).split()], shell=True) |
There was a problem hiding this comment.
It would be possible to run a detached process; this would solve your "Time elapsed" problem. I don't know if it's possible to make it automatically attach to the current terminal session though.
There was a problem hiding this comment.
That was my original idea, but I've often witnessed subpar UX with detached processes. For instance, if you press Ctrl + C in the terminal, it won't close the detached process like you'd expect.
Calinou
force-pushed
the
scons-add-run-option
branch
from
cdb6d53 to
e6c5234
Compare
This makes the compile-test cycle faster for engine contributors, as you no longer need to manually run the engine binary after it's done compiling. This can also avoid distractions that occur when you leave the engine building in the background and forget to run the project/editor afterwards.
Calinou
force-pushed
the
scons-add-run-option
branch
from
e6c5234 to
e232d1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the compile-test cycle faster for engine contributors, as you no longer need to manually run the engine binary after it's done compiling. This can also avoid distractions that occur when you leave the engine building in the background and forget to run the project/editor afterwards.
runoption to SCons to automatically run an engine binary after it was compiled godot-proposals#11719.Examples
Preview
TODO
Time elapsedcalculation and text to be printed before the engine starts. This way, we don't take the engine runtime into account.