Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated +build directive #1175

Closed
ccoVeille opened this issue Nov 6, 2024 · 1 comment
Closed

Remove outdated +build directive #1175

ccoVeille opened this issue Nov 6, 2024 · 1 comment
Labels
go Pull requests that update Go code

Comments

@ccoVeille
Copy link
Contributor

The code is still using the old +build directives from the sources

https://go.googlesource.com/proposal/+/master/design/draft-gobuild.md

We could remove all +build directives, as we have to go:build ones

This is similar to what has been done in testify stretchr/testify#1671

Originally posted by @ccoVeille in #1158 (comment)
@vipul-rawat vipul-rawat added the go Pull requests that update Go code label Nov 7, 2024
@Umang01-hash Umang01-hash mentioned this issue Nov 11, 2024
Merged
4 tasks
@ccoVeille
Copy link
Contributor Author

Fixed by #1185

@ccoVeille ccoVeille mentioned this issue Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ccoVeille @vipul-rawat