Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation bug: wrong observation and action spaces ordering #483

Open
Velythyl opened this issue May 2, 2024 · 3 comments
Open

Documentation bug: wrong observation and action spaces ordering #483

Velythyl opened this issue May 2, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Velythyl
Copy link

Velythyl commented May 2, 2024

I'm currently doing a project related to transferring control policies from simulator to simulator. This lead me to try to standardize action and observation spaces between brax and mujoco.

I implemented wrappers that map the obs and action spaces from mujoco to brax, according to each's table description

I found out that gymnasium's mujoco and gym's mujoco report different index orders for the action and observation spaces.
Farama-Foundation/Gymnasium#1035

I then tried completely removing my mapping wrapper (maps mujoco's obs and action orders to brax's), only to find that my agent transfers a LOT better to mujoco from brax.

All this to say, I'm fairly sure that brax's doc reports the wrong ordering for the action and observation spaces (at least for Ant) and that gymnasium's doc should by copy-pasted into brax

@Velythyl Velythyl changed the title Documentation bug Documentation bug: wrong observation and action spaces ordering May 2, 2024
@btaba
Copy link
Collaborator

btaba commented May 3, 2024

Thanks for the bug report! Please feel free to open up a PR!

@Velythyl
Copy link
Author

Velythyl commented May 24, 2024

Hey! I'll get on that a bit later, been very busy with my own stuff lately

Another report: Humanoid reports a 376-space obs in both gymnasium and brax. For gymnasium it is true, for brax it is actually 244-spaced. This feels like a more difficult discrepancy to fix, probably due to Brax packing joints together during the mujoco compilation?

image

image

@Velythyl
Copy link
Author

Same thing for HumanoidStandup

@btaba btaba added the good first issue Good for newcomers label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants