Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

top-level go directive in go.mod is now unnecessarily restrictive? #3422

Closed
dnwe opened this issue Jan 7, 2025 · 4 comments · Fixed by #3423
Closed

top-level go directive in go.mod is now unnecessarily restrictive? #3422

dnwe opened this issue Jan 7, 2025 · 4 comments · Fixed by #3423
Assignees

Comments

@dnwe
Copy link
Contributor

dnwe commented Jan 7, 2025

Since #3410 the go directive in the top-level go.mod for the go-github library was bumped to an absolute of 1.22.10 here which now requires all consumers to be building with the latest 1.22.10 release of Go 1.22 — this seems unnecessarily restrictive for a library module, particularly as the code itself doesn't currently use any modern language constructs and builds fine even with Go 1.19. Could we at least relax the go directive to 1.22.0 on the assumption that you're doing it to only support the latest N-1 and N releases of the Go toolchain?

@dnwe
Copy link
Contributor Author

dnwe commented Jan 7, 2025

(@gmlewis FYI)

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 7, 2025

@dnwe - yes, there have been several discussions about this before we changed this, and this is the first feedback we have received.

I have no problem with a more relaxed directive to revert back to former behavior.

Please submit a PR that satisfies your requirements.

@gmlewis
Copy link
Collaborator

gmlewis commented Jan 7, 2025

Please make sure to update the README.md clearly stating the policy you would like us to adhere to, moving forward.

@dnwe
Copy link
Contributor Author

dnwe commented Jan 7, 2025

Raised #3423 with a proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants