-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to install-action
#78
Comments
Hi @mgeisler , I am interested in working on this. According to the guide, releases are needed to generate the manifest.Would it be possible to include binaries for Windows, macOS, and Linux in future releases (#79)? This would make it much easier to add mdbook-i18n-helpers to install-action. Please let me know if I'm wrong or need some other resources. |
Hi @miroim, nice to meet you! Thanks for looking into this. I agree we should generate binaries as part of the release — could you look into how people normally do that? My Rust projects have mostly been libraries so far, and there nobody asked for binaries to be released 🙂 I use https://github.com/mgeisler/rust-release-gh-action for releasing my libraries and I would like to use it here too (eventually). Right now, the action requires a |
Thank you for sharing your thoughts. Typically, binaries for different platforms are generated within the CI pipeline. This ensures that the binaries are built automatically and are readily available for each release. |
That's the best way for this kind of thing! Then you can (force-)push as much as you want and get quick feedback! |
This is from our nightly release pipeline: For inspiration:
I'm currently adapting all of that for building a tag after releasing a new version. |
It would be cool if one could install mdbook-i18n-helpers using install-action.
The text was updated successfully, but these errors were encountered: