From c1b2e7814155b05fec78366c3000edc9741af193 Mon Sep 17 00:00:00 2001 From: hai007 Date: Wed, 9 Oct 2024 18:43:22 -0700 Subject: [PATCH] [Sharing Analytics] Log event for bandwidth quality change. PiperOrigin-RevId: 684246964 --- proto/sharing_enums.proto | 7 ++++++- sharing/proto/analytics/nearby_sharing_log.proto | 10 +++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/proto/sharing_enums.proto b/proto/sharing_enums.proto index 158908c2ad7..9928e006ee2 100644 --- a/proto/sharing_enums.proto +++ b/proto/sharing_enums.proto @@ -32,7 +32,7 @@ option objc_class_prefix = "GNSHP"; // in NearbyClearcutLogger (for android, or clearcut_event_logger as the // equivalence for Windows) for all events (may exclude settings), and // session_id for a pair of events (start and end of a session). -// Next id: 68 +// Next id: 70 enum EventType { UNKNOWN_EVENT_TYPE = 0; @@ -297,6 +297,11 @@ enum EventType { // Show accept button on Quick Share receive UI WAITING_FOR_ACCEPT = 67; + // High quality event setup + HIGH_QUALITY_MEDIUM_SETUP = 68; + + // Hight quality event setup timeout + HIGH_QUALITY_MEDIUM_TIMEOUT = 69; // LINT.ThenChange(//depot/google3/location/nearby/proto/nearby_event_codes.proto:SharingEventCode) } diff --git a/sharing/proto/analytics/nearby_sharing_log.proto b/sharing/proto/analytics/nearby_sharing_log.proto index 154000ed003..f3aa2f6e301 100644 --- a/sharing/proto/analytics/nearby_sharing_log.proto +++ b/sharing/proto/analytics/nearby_sharing_log.proto @@ -31,7 +31,7 @@ option objc_class_prefix = "GNCP"; // Top-level log proto for all NearbySharing logging. // Each log contains a key (event_type), value (a verb-noun event) pair. -// Next Tag: 77 +// Next Tag: 78 // LINT.IfChange message SharingLog { /* collection_basis = { @@ -210,6 +210,8 @@ message SharingLog { optional ShowWaitingForAccept show_waiting_for_accept = 76; + optional HighQualityMedium high_quality_medium = 77; + // Used only for Nearby Share Windows app now. message AppInfo { // e.g. "1.0.408" @@ -895,5 +897,11 @@ message SharingLog { message ShowWaitingForAccept { optional location.nearby.proto.sharing.ButtonStatus button_status = 1; } + + message HighQualityMedium { + optional int64 session_id = 1 /* type = ST_SESSION_ID */; + optional location.nearby.proto.connections.Medium medium = 2; + optional int64 duration_millis = 3; + } } // LINT.ThenChange(//depot/google3/logs/proto/location/nearby/nearby_client_log.proto)