Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contrast/borders of the scroll-able accordion containers #1578

Open
hogo6002 opened this issue Feb 6, 2025 · 3 comments
Open

Improve contrast/borders of the scroll-able accordion containers #1578

hogo6002 opened this issue Feb 6, 2025 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@hogo6002
Copy link
Contributor

hogo6002 commented Feb 6, 2025

No description provided.

@vitorRibeiro7
Copy link

Hi @hogo6002, I would like to work on this issue.

Can you assign me?

@another-rex
Copy link
Collaborator

Assigned to you. @vitorRibeiro7

Here's some details on what needs to be done.

Example HTML report: https://another-rex.github.io/TestPages/Vulnerability%20Scan%20Report.html

We would like to have some sort of scroll drop shadow, e.g. https://css-tricks.com/books/greatest-css-tricks/scroll-shadows/
at the top and bottom.

To get a similar report to this locally, run the following:

# If you have docker installed
go run ./cmd/osv-scanner/ scan image --serve nginx:1.22
# If not, try:
git checkout https://github.com/hogo6002/scanner-comparison.git
go run ./cmd/osv-scanner/ scan source --serve -r ./scanner-comparison

The files you need are here:
internal/output/html/

Screen.recording.2025-02-07.10.26.07.AM.webm

@vitorRibeiro7
Copy link

Hi @another-rex, I worked on this shadow detail that you suggested, but I managed to make this shadow disappear when there was no scrolling, but I couldn't make it work in a pleasant way, from my point of view, even with the shadow appearing all the time, it still looks nice, do you think we can leave it that way or not? I also improved the scroll style.

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants