Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf wrapper types not recognized as REST query parameters #14491

Closed
scotthart opened this issue Jul 18, 2024 · 1 comment · Fixed by #14493
Closed

protobuf wrapper types not recognized as REST query parameters #14491

scotthart opened this issue Jul 18, 2024 · 1 comment · Fixed by #14493
Assignees
@scotthart
Labels
api: bigquery Issues related to the BigQuery API. cpp: generator Issues related to the C++ micro-generator type: cleanup An internal cleanup or hygiene concern.

Comments

@scotthart
Copy link
Member

for http GET operations we typically extract all non-repeated, non-aggregate typed fields found in the request proto we pull out and make query parameters in the request url. BigQuery protos often use google.protobuf.BoolValue or google.protobuf.UInt32Value instead of the native bool and uint32. The generator needs to treat these wrapped types as if they were the underlying type.
@scotthart scotthart added type: cleanup An internal cleanup or hygiene concern. api: bigquery Issues related to the BigQuery API. cpp: generator Issues related to the C++ micro-generator labels Jul 18, 2024
@scotthart scotthart self-assigned this Jul 18, 2024
@scotthart scotthart mentioned this issue Jul 18, 2024
Merged
@scotthart
Copy link
Member Author

This issue is a special case of #14492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scotthart scotthart

Labels
api: bigquery Issues related to the BigQuery API. cpp: generator Issues related to the C++ micro-generator type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

impl(generator): support protobuf wrapper types as query params scotthart/google-cloud-cpp
1 participant
@scotthart